Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove moment from frontend components #882

Merged
merged 3 commits into from
Dec 5, 2021

Conversation

halkeye
Copy link
Member

@halkeye halkeye commented Dec 5, 2021

this includes #881 but i can't make it the base because its cross repos :(

60f4702 is just this PR

@halkeye halkeye requested a review from a team as a code owner December 5, 2021 07:20
@halkeye
Copy link
Member Author

halkeye commented Dec 5, 2021

Aww, not as big of a difference in bundle size as I had expected. About 600kb I guess? It almost halves the javascript so its decent chunk for such minor code.

I'll fix in the morning

80K     public.withmoment/app-6fcd76498bca9bab1b60.js
8.0K    public.withmoment/webpack-runtime-efd964d831f06a1e1d7a.js
68K     public.withmoment/475b43a2c111b292263b3b15eceabe4113ae093d-6d0dc6caa623c6b84def.js
128K    public.withmoment/component---src-templates-plugin-jsx-d78271b9b3554e69f8a0.js
64K     public.withmoment/component---src-templates-search-jsx-79ccd0cee93e2dcd2606.js
4.0K    public.withmoment/503-8d40d5484e76862e0fde.js
176K    public.withmoment/36bcf0ca-288d2f2e6b7baf3d4583.js
4.0K    public.withmoment/component---src-pages-404-jsx-53a11b7e6aab0af02d11.js
4.0K    public.withmoment/231-cb160452573987d72ae7.js
12K     public.withmoment/component---src-templates-index-jsx-fd084fdd32807869835a.js
8.0K    public.withmoment/webpack-runtime-b87f37c52883e5b9f63a.js
12K     public.withmoment/ccea98d365930d93ee9e4445634996838fc56908-457446be4f62e6dec858.js
88K     public.withmoment/polyfill-cc3142b30ab31ce6b8f0.js
80K     public.withmoment/app-d46b4f3c00b14ce9f6fa.js
4.0K    public.withmoment/component---src-templates-tombstone-jsx-63197a2e90e5c1a05762.js
60K     public.withmoment/component---src-templates-search-jsx-34caf8dab7776ba83546.js
132K    public.withmoment/component---src-templates-plugin-jsx-321c555d2d773d154399.js
128K    public.withmoment/framework-b9d9b8be7b5e743c585b.js
16K     public.withmoment/b64c0a1fb503a9c3f1bdd91277863928065b3659-f5306b6b626d8cb7e3d6.js
1.2M    total
 ☎  ~  …  plugin-site  add-tests  2✎  9+  %    find public.withoutmoment -name '*.js' -exec du -hsc {} +
4.0K    public.withoutmoment/175-0736947a57618247f69c.js
80K     public.withoutmoment/100-2ff500b7af5c4b1daa04.js
40K     public.withoutmoment/commons-e38040d58d39960a3437.js
80K     public.withoutmoment/app-6fcd76498bca9bab1b60.js
64K     public.withoutmoment/component---src-templates-search-jsx-79ccd0cee93e2dcd2606.js
4.0K    public.withoutmoment/503-8d40d5484e76862e0fde.js
176K    public.withoutmoment/36bcf0ca-288d2f2e6b7baf3d4583.js
4.0K    public.withoutmoment/component---src-pages-404-jsx-53a11b7e6aab0af02d11.js
4.0K    public.withoutmoment/231-cb160452573987d72ae7.js
12K     public.withoutmoment/component---src-templates-index-jsx-fd084fdd32807869835a.js
8.0K    public.withoutmoment/webpack-runtime-b87f37c52883e5b9f63a.js
12K     public.withoutmoment/ccea98d365930d93ee9e4445634996838fc56908-457446be4f62e6dec858.js
88K     public.withoutmoment/polyfill-cc3142b30ab31ce6b8f0.js
4.0K    public.withoutmoment/component---src-templates-tombstone-jsx-63197a2e90e5c1a05762.js
132K    public.withoutmoment/component---src-templates-plugin-jsx-321c555d2d773d154399.js
128K    public.withoutmoment/framework-b9d9b8be7b5e743c585b.js
16K     public.withoutmoment/b64c0a1fb503a9c3f1bdd91277863928065b3659-f5306b6b626d8cb7e3d6.js
856K    total

@halkeye halkeye enabled auto-merge December 5, 2021 18:12
@halkeye halkeye merged commit 844d9d9 into jenkins-infra:master Dec 5, 2021
@halkeye halkeye deleted the remove-moment branch December 5, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants