Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basil to throttle-concurrents #1325

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

basil
Copy link
Contributor

@basil basil commented Oct 30, 2019

Description

I would like to become a maintainer of throttle-concurrents, at minimum to release jenkinsci/throttle-concurrent-builds-plugin#57 and jenkinsci/throttle-concurrent-builds-plugin#58.

CC'ing existing maintainers @abayer and @oleg-nenashev as well as @dwnusbaum (who has reviewed some changes in this repository recently).

I realize this plugin has a large number of users and has not been maintained in a while. Therefore there is some degree of risk associated with any change. I have the following plan to mitigate this risk:

  • First, I will get the plugin's CI builds into shape by doing any relevant tooling updates: bumping the plugin parent POM to the latest version, ensuring that the Jenkinsfile uses buildPlugin.recommendedConfigurations(), etc.
  • Next, I will set up Release Drafter and migrate the documentation from the wiki to GitHub.
  • Next I will merge any new tests being added in the two PRs mentioned above. If the tests pass in the existing code, I will not mark them with @Ignore. If the tests fail in the existing code, I will mark them with @Ignore. This provides us with a baseline to ensure that the changes in the PRs don't cause any regressions.
  • Then I will merge the fixes in the two PRs mentioned above. If they cause any @Ignored tests to start passing, I will remove the @Ignore annotation. Each PR has been running on the corresponding author's Jenkins instance for several months without any issues, which helps to mitigate the risk. I will not take in any additional fixes for the initial release.
  • Then I will cut the release. I will monitor Jira and ensure I am available to deal with any possible regressions that are introduced. I will not set up Dependabot or merge any new PRs until several weeks or months have passed by with no regressions. At that point, we can consider slowly doing additional changes to the plugin, as necessary, until it reaches a stable state again.

I am happy to work with any existing maintainers throughout the above process.

Submitter checklist for changing permissions

Always

  • Add link to plugin/component Git repository in description above

When adding new uploaders (this includes newly created permissions files)

Merge permission to GitHub repository

  • Check this if newly added person also needs to be given merge permission to the GitHub repo.

@dwnusbaum
Copy link
Contributor

I am not a maintainer of this plugin, but for the people who are maintainers, I can vouch that @basil has been making some very helpful and careful changes in Pipeline plugins recently, and responding to any followups caused by those changes, for example many refactoring changes like jenkinsci/workflow-job-plugin#136, and bug fixes like jenkinsci/workflow-durable-task-step-plugin#117. The proposed plan to avoid unnecessary risk seems reasonable to me.

@scoheb
Copy link
Contributor

scoheb commented Nov 13, 2019

We would love to see an active maintainer for this plugin! We are already using the changes from the 2 PRs mentioned about and they are working as expected.

Copy link
Contributor

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as a former maintainer. The plugin was up for adoption for few years, and any help will be much appreciated. Thanks Basil! Will do the transfer once I get to the laptop

@slide slide merged commit 0be1596 into jenkins-infra:master Nov 13, 2019
@slide
Copy link
Contributor

slide commented Nov 13, 2019

Github permissions added as well

@basil
Copy link
Contributor Author

basil commented Nov 13, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants