Add basil to throttle-concurrents #1325
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I would like to become a maintainer of
throttle-concurrents
, at minimum to release jenkinsci/throttle-concurrent-builds-plugin#57 and jenkinsci/throttle-concurrent-builds-plugin#58.CC'ing existing maintainers @abayer and @oleg-nenashev as well as @dwnusbaum (who has reviewed some changes in this repository recently).
I realize this plugin has a large number of users and has not been maintained in a while. Therefore there is some degree of risk associated with any change. I have the following plan to mitigate this risk:
Jenkinsfile
usesbuildPlugin.recommendedConfigurations()
, etc.@Ignore
. If the tests fail in the existing code, I will mark them with@Ignore
. This provides us with a baseline to ensure that the changes in the PRs don't cause any regressions.@Ignore
d tests to start passing, I will remove the@Ignore
annotation. Each PR has been running on the corresponding author's Jenkins instance for several months without any issues, which helps to mitigate the risk. I will not take in any additional fixes for the initial release.I am happy to work with any existing maintainers throughout the above process.
Submitter checklist for changing permissions
Always
When adding new uploaders (this includes newly created permissions files)
@
mention an existing maintainer to confirm the permissions request, if applicableMerge permission to GitHub repository