feat(terraform: azure-jenkinsinfra-controller
) allow DNS to use distinct provider or to be undefined
#135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to jenkins-infra/helpdesk#3913 (edited).
Migrating the controller VM to the new subscription will need instantiating the module
azure-jenkinsinfra-controller
(either a new one or the current one). This module takes care of creating not only the VM, but also DNS records to reach this VM. But as our DNS zones for thejenkins.io
andjenkins-ci.org
domains are NOT in the secondary (sponsored) subscription, it will be an obstacle.As a remidation, this PR adds a new feature to the terraform module
azure-jenkinsinfra-controller
to allow DNS records:So we can handle many cases during the migration of ci.jenkins.io
Tested with success:
terraform plan
against the 3 existing controllers: