chore: Update jx dependency, fix logic for secrets #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
|
/hold |
Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
It should use the config map value if available (previously we were passing the whole path and that isn't the key name so) or the file in $JX_HOME if not. Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
abayer
force-pushed
the
bump-to-jx-as-of-jan-10-2020
branch
from
657ecb1 to
e2cb82a
Compare
|
Think I fixed it in e2cb82a |
|
Dangit, UI tests are still going to fail. |
abayer
changed the title
Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
|
/retest |
|
/hold cancel |
2 tasks
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: garethjevans The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the error in the quickstart tests. Probably doesn't fix everything, but hey.
cc @daveconde