Merge pull request #301 from nekator/fix/GH300

fix: GH-300
jenkins-x · Oct 12, 2022 · 3499e7d · 3499e7d
2 parents e7ee88a + d60cf96
commit 3499e7d
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 8 deletions.
diff --git a/scm/driver/gitlab/testdata/webhooks/pull_request_close.json b/scm/driver/gitlab/testdata/webhooks/pull_request_close.json
@@ -37,7 +37,7 @@
     "merge_commit_sha": null,
     "merge_error": null,
     "merge_params": {
-      "force_remove_source_branch": "0"
+      "force_remove_source_branch": false
     },
     "merge_status": "can_be_merged",
     "merge_user_id": null,

diff --git a/scm/driver/gitlab/testdata/webhooks/pull_request_comment_create.json b/scm/driver/gitlab/testdata/webhooks/pull_request_comment_create.json
@@ -69,7 +69,7 @@
     "merge_commit_sha": null,
     "merge_error": null,
     "merge_params": {
-      "force_remove_source_branch": "0"
+      "force_remove_source_branch": false
     },
     "merge_status": "can_be_merged",
     "merge_user_id": null,

diff --git a/scm/driver/gitlab/testdata/webhooks/pull_request_create.json b/scm/driver/gitlab/testdata/webhooks/pull_request_create.json
@@ -37,7 +37,7 @@
     "merge_commit_sha": null,
     "merge_error": null,
     "merge_params": {
-      "force_remove_source_branch": "0"
+      "force_remove_source_branch": false
     },
     "merge_status": "unchecked",
     "merge_user_id": null,

diff --git a/scm/driver/gitlab/testdata/webhooks/pull_request_edited.json b/scm/driver/gitlab/testdata/webhooks/pull_request_edited.json
@@ -37,7 +37,7 @@
     "merge_commit_sha": null,
     "merge_error": null,
     "merge_params": {
-      "force_remove_source_branch": "0"
+      "force_remove_source_branch": false
     },
     "merge_status": "unchecked",
     "merge_user_id": null,

diff --git a/scm/driver/gitlab/testdata/webhooks/pull_request_merge.json b/scm/driver/gitlab/testdata/webhooks/pull_request_merge.json
@@ -37,7 +37,7 @@
     "merge_commit_sha": "78a76ee6b4992a6baf64c59fc4c44c7323d60438",
     "merge_error": null,
     "merge_params": {
-      "force_remove_source_branch": "0"
+      "force_remove_source_branch": false
     },
     "merge_status": "can_be_merged",
     "merge_user_id": null,

diff --git a/scm/driver/gitlab/testdata/webhooks/pull_request_reopen.json b/scm/driver/gitlab/testdata/webhooks/pull_request_reopen.json
@@ -37,7 +37,7 @@
     "merge_commit_sha": null,
     "merge_error": null,
     "merge_params": {
-      "force_remove_source_branch": "0"
+      "force_remove_source_branch": false
     },
     "merge_status": "can_be_merged",
     "merge_user_id": null,

diff --git a/scm/driver/gitlab/webhook.go b/scm/driver/gitlab/webhook.go
@@ -613,7 +613,7 @@ type (
 			MergeCommitSha string      `json:"merge_commit_sha"`
 			MergeError     interface{} `json:"merge_error"`
 			MergeParams    struct {
-				ForceRemoveSourceBranch string `json:"force_remove_source_branch"`
+				ForceRemoveSourceBranch bool `json:"force_remove_source_branch"`
 			} `json:"merge_params"`
 			MergeStatus               string      `json:"merge_status"`
 			MergeUserID               interface{} `json:"merge_user_id"`
@@ -698,7 +698,7 @@ type (
 			MergeCommitSha string      `json:"merge_commit_sha"`
 			MergeError     interface{} `json:"merge_error"`
 			MergeParams    struct {
-				ForceRemoveSourceBranch string `json:"force_remove_source_branch"`
+				ForceRemoveSourceBranch bool `json:"force_remove_source_branch"`
 			} `json:"merge_params"`
 			MergeStatus               string      `json:"merge_status"`
 			MergeUserID               interface{} `json:"merge_user_id"`