-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove merge_params.force_remove_source_branch #339
Conversation
…y used with int and boolean
Hi @philhug. Thanks for your PR. I'm waiting for a jenkins-x or todo member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…y used with int and boolean
LastEditedByID interface{} `json:"last_edited_by_id"` | ||
MergeCommitSha string `json:"merge_commit_sha"` | ||
MergeError interface{} `json:"merge_error"` | ||
MergeParams interface{} `json:"-"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this removed? Should it be changed instead to
ForceRemoveSourceBranch bool `json:"force_remove_source_branch"`
and verified that gitlab sends boolean instead of string (also fix testdata)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closing this in favour of #301 |
Fixes failed webhooks if remove source branch is enabled on branch.
Closes: #300