Skip to content
This repository has been archived by the owner on Mar 2, 2024. It is now read-only.

fix: fix helm stable repo deprecation and upgrade helm version to 2.17.0 in jx preinstall step for builder images #1098

Merged
merged 3 commits into from
Dec 28, 2020

Conversation

rawlingsj
Copy link
Member

No description provided.

…7.0 in jx preinstall step for builder images
@rawlingsj
Copy link
Member Author

/test tekton

@rawlingsj
Copy link
Member Author

BDD test got passed the helm repo issues we were seeing before, the tekton failure was because of a jacoco app error, think this should fix that jenkins-x/bdd-jx@eec7628. So retriggered tekton to see while the other BDD tests are still running.

@rawlingsj
Copy link
Member Author

BDD tests were failing, looks like the newer helm CLI has different behaviour, I'm hoping this will fix it jenkins-x/jenkins-x-builders-base@d50e8b1

Will need for that to be released and flow through the pipelines.

@rawlingsj
Copy link
Member Author

/test all

@rawlingsj
Copy link
Member Author

lets override the contexts that are not on by default as they were wrongly triggered with the test all comment earlier
/override boot-helm3
/override boot-helm3-mc
/override boot-vault-tls
/override bucketrepo

@jenkins-x-bot
Copy link
Contributor

@rawlingsj: Overrode contexts on behalf of rawlingsj: boot-helm3, boot-helm3-mc, boot-vault-tls, bucketrepo

In response to this:

lets override the contexts that are not on by default as they were wrongly triggered with the test all comment earlier
/override boot-helm3
/override boot-helm3-mc
/override boot-vault-tls
/override bucketrepo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@rawlingsj
Copy link
Member Author

/test tekton

@jenkins-x-bot
Copy link
Contributor

jenkins-x-bot commented Dec 28, 2020

@rawlingsj: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
boot-helm3 4cbbe9e link /test boot-helm3
boot-helm3-mc 4cbbe9e link /test boot-helm3-mc
bucketrepo 4cbbe9e link /test bucketrepo
boot-vault-tls 4cbbe9e link /test boot-vault-tls

View all Builds for this Pull Request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@rawlingsj
Copy link
Member Author

/test boot-local

@rawlingsj
Copy link
Member Author

/test boot-vault

@rawlingsj
Copy link
Member Author

/approve

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rawlingsj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit b70dfc2 into jenkins-x:master Dec 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants