fix: GetApps doesn't need to preserve its clone directory so can

always be temporary.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>

pkg/apps/gitops.go

@@ -167,15 +167,14 @@ func (o *GitOpsOptions) DeleteApp(app string, alias string, autoMerge bool) erro
 
 // GetApps retrieves all the apps information for the given appNames from the repository and / or the CRD API
 func (o *GitOpsOptions) GetApps(appNames map[string]bool, expandFn func([]string) (*v1.AppList, error)) (*v1.AppList, error) {
-	dir := o.EnvironmentCloneDir
-	if dir == "" {
-		tmpDir, err := ioutil.TempDir("", "get-apps-")
-		if err != nil {
-			return nil, err
-		}
-		defer os.RemoveAll(tmpDir)
-		dir = tmpDir
+	// AddApp, DeleteApp, and UpgradeApps delegate selecting/creating the directory to clone in to environments/gitops.go's
+	// Create function, but here we need to create the directory explicitly. since we aren't calling Create, because we're
+	// not creating a pull request.
+	dir, err := ioutil.TempDir("", "get-apps-")
+	if err != nil {
+		return nil, err
 	}
+	defer os.RemoveAll(dir)
 
 	gitInfo, err := gits.ParseGitURL(o.DevEnv.Spec.Source.URL)
 	if err != nil {

pkg/cmd/get/get_apps.go

@@ -26,9 +26,6 @@ type GetAppsOptions struct {
 	ShowStatus bool
 	GitOps     bool
 	DevEnv     *v1.Environment
-
-	// Used for testing
-	CloneDir string
 }
 
 type appsResult struct {
@@ -155,7 +152,6 @@ func (o *GetAppsOptions) Run() error {
 		}
 		installOptions.GitProvider = gitProvider
 		installOptions.Gitter = o.Git()
-		installOptions.EnvironmentCloneDir = o.CloneDir
 	}
 
 	apps, err := installOptions.GetApps(o.Args)