Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jx step helm apply should use a temporary directory #4383

Closed
jstrachan opened this issue Jun 24, 2019 · 0 comments · Fixed by #4384
Closed

jx step helm apply should use a temporary directory #4383

jstrachan opened this issue Jun 24, 2019 · 0 comments · Fixed by #4384
Assignees
@jstrachan
Labels
area/install kind/enhancement An enhancement of an existing feature

Comments

@jstrachan
Copy link
Member

given that we can have a tree of values.yaml files and we can template them to bind parameters from secret URLs in vault or local files #4328 - we want to be super careful not to populate the local values.yaml file in git with either redundant content from a sub directory's values.yaml file or much much worse - with secret values.

So lets make sure that jx step env apply defaults to creating a temporary directory and copying the source for the helm directory into the temp dir and building and applying charts from there.

This also avoids issues with cached charts in the charts folders from causing issues as versions of charts change or charts get enabled/disabled without explicitly clearing down the charts folders
@jstrachan jstrachan added kind/enhancement An enhancement of an existing feature area/install labels Jun 24, 2019
@jstrachan jstrachan self-assigned this Jun 24, 2019
jstrachan added a commit to jstrachan/jx that referenced this issue Jun 24, 2019
@jstrachan
fix: default to use a temporary directory for applying helm charts
fb2b093 
fixes jenkins-x#4383

Signed-off-by: James Strachan <james.strachan@gmail.com>
@jstrachan jstrachan mentioned this issue Jun 24, 2019
Merged
jenkins-x-bot pushed a commit that referenced this issue Jun 24, 2019
@jstrachan @jenkins-x-bot
fix: default to use a temporary directory for applying helm charts (#…
3e39386 
…4384)

* fix: default to use a temporary directory for applying helm charts

fixes #4383

Signed-off-by: James Strachan <james.strachan@gmail.com>

* fix: lets use https for spring boot model

Signed-off-by: James Strachan <james.strachan@gmail.com>
daveconde pushed a commit to daveconde/jx that referenced this issue Apr 7, 2020
@jstrachan
fix: default to use a temporary directory for applying helm charts (j…
b60ba73 
…enkins-x#4384)

* fix: default to use a temporary directory for applying helm charts

fixes jenkins-x#4383

Signed-off-by: James Strachan <james.strachan@gmail.com>

* fix: lets use https for spring boot model

Signed-off-by: James Strachan <james.strachan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jstrachan jstrachan

Labels
area/install kind/enhancement An enhancement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: default to use a temporary directory for applying helm charts jstrachan/jx
1 participant
@jstrachan