Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename jx step create install values to something more accurate #5020

Closed
jstrachan opened this issue Aug 7, 2019 · 0 comments · Fixed by #6634
Closed

rename jx step create install values to something more accurate #5020

jstrachan opened this issue Aug 7, 2019 · 0 comments · Fixed by #6634
Labels
area/boot issues in the `jx boot` command kind/enhancement An enhancement of an existing feature priority/important-longterm

Comments

@jstrachan
Copy link
Member

e.g. maybe we call it jx step verify ingress as its run after setting up ingress and to verify things + if there's no domain, populating .nip.io domain from the ingress load balancer IP etc

we could leave the old alias in place until folks have migrated to the latest boot config with the new step?
@jstrachan jstrachan added kind/enhancement An enhancement of an existing feature area/boot issues in the `jx boot` command labels Aug 7, 2019
jstrachan added a commit to jstrachan/jx that referenced this issue Jan 28, 2020
@jstrachan
fix: alias 'jx step create install values' -> 'jx step verify ingress'
41e32af 
to simplify the UX

fixes jenkins-x#5020

Signed-off-by: James Strachan <james.strachan@gmail.com>
@jstrachan jstrachan mentioned this issue Jan 28, 2020
Merged
jstrachan added a commit to jstrachan/jx that referenced this issue Jan 29, 2020
@jstrachan
fix: alias 'jx step create install values' -> 'jx step verify ingress'
dd2c7c8 
to simplify the UX

fixes jenkins-x#5020

Signed-off-by: James Strachan <james.strachan@gmail.com>
jenkins-x-bot pushed a commit that referenced this issue Jan 29, 2020
@jstrachan @jenkins-x-bot
fix: alias 'jx step create install values' -> 'jx step verify ingress'
a0702a8 
to simplify the UX

fixes #5020

Signed-off-by: James Strachan <james.strachan@gmail.com>
daveconde pushed a commit to daveconde/jx that referenced this issue Apr 7, 2020
@jstrachan
fix: alias 'jx step create install values' -> 'jx step verify ingress'
d27e925 
to simplify the UX

fixes jenkins-x#5020

Signed-off-by: James Strachan <james.strachan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/boot issues in the `jx boot` command kind/enhancement An enhancement of an existing feature priority/important-longterm
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: alias 'jx step create install values' -> 'jx step verify ingress' jstrachan/jx
2 participants
@jstrachan @daveconde