Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PipelineBaseTest): callstackdump should be updated if callstack is changed #665

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

stchar
Copy link
Contributor

@stchar stchar commented Jul 8, 2024

dumpCallStask should respect helper.callStack if it was changed.

fixes #664

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@stchar stchar requested a review from nre-ableton July 12, 2024 17:56
Copy link
Contributor

@nre-ableton nre-ableton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@nre-ableton nre-ableton merged commit 70482cb into master Jul 15, 2024
10 checks passed
@nre-ableton nre-ableton deleted the bugfix/call-stack-dump branch July 15, 2024 19:35
@nre-ableton
Copy link
Contributor

(BTW, I'll try to make a release this week, but I'm quite busy the next few days).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

You cannot call printCallStack or assertCallStack in the middle of your test
2 participants