-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Jenkinsfile for parallelized ATH runs via Pipeline #157
Conversation
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
git changelog: false, poll: false, url: "git://github.com/" + functionsRepo, branch: functionsBranch | ||
|
||
functions = load 'lib/functions.groovy' | ||
ath = load 'lib/ath.groovy' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any value in sharing ath.groovy
? I doubt anybody would use it without ATH sources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main reasoning is so we can eventually branch the ATH without also forking the build tooling, if that makes any sense. And so we can have multiple jobs that use the ATH but may not all be building against the same branch etc...
@abayer what is the status of this? |
I need to resurrect this. Will try to do so next week.
|
Closing this. |
Sad, no plans for this? |
Once I will get the docker tests running in #238, parallel test execution is the next thing to look at. |
Note - this depends on https://github.com/jenkinsci/jenkins-project-pipeline-lib/pull/1.
This is descended from how we've been doing ATH runs internally at CloudBees - loading most of the logic from Pipeline libraries, splitting the ATH into a number of separate parallel blocks using the Parallel Test Executor plugin, and then pulling all the results back together in the end.
The plan is to start using this for the non-PR-triggered ATH builds on jenkins.ci.cloudbees.com, with the PR builds moved out to a separate, still linear job for now. Until JENKINS-33274 is resolved, multibranch jobs will have to run all the tests serially for the first build on each branch or PR anyway, but the main reason is that we'll simply exhaust our executor resources on jenkins.ci.cloudbees.com with PR builds. Down the road, once we've got JENKINS-30412, we should hopefully be able to get some logic in place to figure out what tests have changed/are relevant to a given PR so that we can avoid having to run all the tests for every PR.
cc @jenkinsci/code-reviewers, @reviewbybees, @olivergondza, @jtnord