Fix release process by restoring groupId #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plugin groupId was changed in the pom file after the release of 1.10. That change caused the release of 1.11 and 1.12 to fail. The last release available from the Jenkins update center is 1.10. There have been significant changes in the master branch of the plugin since the release of 1.10. Rather than risk breaking compatibility for existing users of the 1.10 release, I've removed the incorrect change of groupId and accepted that this plugin cannot be released without testing those changes. I'm not a user of the plugin. I'm not willing to perform that testing. If someone else wants to adopt the plugin, perform the additional testing, and release a new version, this change is a necessary but not sufficient step towards that release. Compare the current code to the 1.10 tag for the details of the changes made since the 1.10 release. https://issues.jenkins.io/browse/JENKINS-70301 describes the relationship between this plugin and the WMI Windows Agents plugin. Users that want to remove the WMI Windows Agents plugin will also need to remove this plugin or they will need to wait until jenkinsci/jenkins#7568 is available in Jenkins core 2.386 or newer.
If someone adopts this plugin, they need to know that there are many changes on the master branch that have not been delivered to users and may surprise users with compatibility issues or other problems.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the release process by restoring original groupId
The plugin groupId was changed in the pom file after the release of 1.10. That change caused the release of 1.11 and 1.12 to fail. The last release available from the Jenkins update center is 1.10.
There have been significant changes in the master branch of the plugin since the release of 1.10. Rather than risk breaking compatibility for existing users of the 1.10 release, I've removed the incorrect change of groupId and accepted that this plugin cannot be released without testing those changes.
I'm not a user of the plugin. I'm not willing to perform that testing. If someone else wants to adopt the plugin, perform the additional testing, and release a new version, this change is a necessary but not sufficient step towards that release.
Compare the current code to the 1.10 tag for the details of the changes made since the 1.10 release.
https://issues.jenkins.io/browse/JENKINS-70301 describes the relationship between this plugin and the WMI Windows Agents plugin. Users that want to remove the WMI Windows Agents plugin will also need to remove this plugin or they will need to wait until jenkinsci/jenkins#7568 is available in Jenkins core 2.386 or newer.