Fix parsing of clang warnings with "C/C++:" prefix

[DennisBauer]

The prefix was detected as part of the file name
leading to a java.nio.file.InvalidPathException
in IssueBuilder.isAbsolutePath().
In addition to fixing the path parsing in ClangParser
the Exception thrown in the IssueBuilder.isAbsolutePath()
is also catched.

Testing done

Submitter checklist

Preview Give feedback

1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
2. Ensure that the pull request title represents the desired changelog entry
3. Please describe what you did
4. Link to relevant issues in GitHub or Jira
5. Link to relevant pull requests, esp. upstream and downstream changes
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (daece32) 89.71% compared to head (3460211) 89.68%.
Report is 9 commits behind head on main.

Files	Patch %	Lines
...main/java/edu/hm/hafner/analysis/IssueBuilder.java	50.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1021      +/-   ##
============================================
- Coverage     89.71%   89.68%   -0.03%     
  Complexity     2284     2284              
============================================
  Files           354      354              
  Lines          6690     6692       +2     
  Branches        698      698              
============================================
  Hits           6002     6002              
- Misses          486      488       +2     
  Partials        202      202              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[uhafner]

Thanks for the PR!

The prefix was detected as part of the file name leading to a java.nio.file.InvalidPathException in IssueBuilder.isAbsolutePath().

Can you please also expose this bug in a test for IssueBuilder and then catch this Exception in IssueBuilder and return false?

[DennisBauer]

I was also thinking about this but it's not clear what to return for isAbsolutePath(). Returning false will treat it as relative path, potentially adding a prefix path, which will probably make it fail somewhere else.

[uhafner]

I was also thinking about this but it's not clear what to return for isAbsolutePath(). Returning false will treat it as relative path, potentially adding a prefix path, which will probably make it fail somewhere else.

Well, you can also return true if you think that would fit better. But in all other places invalid paths are catched and ignored.

[DennisBauer]

If we cannot check whether the path is an absolute path or not neither returning true nor false makes sense to me. But if you're saying that the invalid path is also catched at other places I can do the same in isAbsolutePath() and return true.

[uhafner]

Normally a test would be required, but since I added one in uhafner/codingstyle#921 we can ignore it right here.

[uhafner]

Thanks!