Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for the IAR CSTAT tool #103

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Conversation

DaMutz
Copy link

@DaMutz DaMutz commented Feb 28, 2019

try to add support for the IAR CSTAT tool

@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #103 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #103      +/-   ##
===========================================
+ Coverage     86.34%   86.4%   +0.05%     
- Complexity     1182    1189       +7     
===========================================
  Files           158     159       +1     
  Lines          3816    3832      +16     
  Branches        425     426       +1     
===========================================
+ Hits           3295    3311      +16     
  Misses          358     358              
  Partials        163     163
Impacted Files Coverage Δ Complexity Δ
.../edu/hm/hafner/analysis/parser/IarCstatParser.java 100% <100%> (ø) 7 <7> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9fed38...8ea8636. Read the comment docs.

@uhafner uhafner merged commit f537361 into jenkinsci:master Feb 28, 2019
@uhafner
Copy link
Member

uhafner commented Feb 28, 2019

Thank you very much!

We have two ways to present this parser in the UI:

  1. The parser can run automatically if the user selects the IAR Parser.
  2. We can create an additional class in the sense of Iar

What makes more sense for you?

uhafner added a commit that referenced this pull request Feb 28, 2019
@DaMutz DaMutz deleted the cstat_support branch March 2, 2019 13:47
@DaMutz
Copy link
Author

DaMutz commented Mar 2, 2019

Thank you very much!

We have two ways to present this parser in the UI:

  1. The parser can run automatically if the user selects the IAR Parser.
  2. We can create an additional class in the sense of Iar

What makes more sense for you?

Thank you for merging my change into the master.

For me number 2 makes more sense, because probably you do not want to include the C-Stat warnings in the UI / graph, with way number 2 it gives the full possibility to set it like this.
I will do a pull-request for the changes in the warnings-ng-plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants