Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor type: make the report aware of parser properties #1111

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Refactor type: make the report aware of parser properties #1111

wants to merge 3 commits into from

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Nov 27, 2024 •
edited
Loading

Make some additional properties available in the serialization of a report:

  • icon of a report
  • originating parser ID
  • type of the warnings

@uhafner uhafner added enhancement Enhancement of existing functionality breaking Breaking Changes labels Nov 27, 2024
@github-actions GitHub Actions
Copy link

☀️   Quality Monitor

   🚦   Tests: 100% successful (❌ 2 failed, ✔️ 1291 passed, 🙈 2 skipped)
   〰️   Line Coverage: 93% (433 missed lines)
   ➰   Branch Coverage: 87% (272 missed branches)
   CheckStyle   CheckStyle: 2 warnings (normal: 2)
   PMD   PMD: No warnings
   SpotBugs   SpotBugs: 1 bug (low: 1)
   🐛   Error Prone: 26 bugs (normal: 26)
   OWASP Dependency Check   OWASP Dependency Check: No vulnerabilities
   🌀   Cyclomatic Complexity: 2315 (total)
   💭   Cognitive Complexity: 1135 (total)
   📏   Lines of Code: 21862 (total)
   📝   Non Commenting Source Statements: 8762 (total)
   🔭   Access to foreign data: 1374 (total)
   🔗   Class cohesion: 100.00% (maximum)
   📤   Fan out: 3038 (total)
   📲   Number of accessors: 174 (total)
   ⚖️   Weight of a class: 100.00% (maximum)
   📐   Weighted method count: 2676 (total)
   ➿   N-Path Complexity: 3791 (total)

🚧   Error Messages

Quality Monitor Errors:
No matching report files found when using pattern '**/target/dependency-check-report.json'! Configuration error for 'OWASP Dependency Check'?

Created by Quality Monitor v1.14.0 (#f3859fd). More details are shown in the GitHub Checks Result.

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 16, 2024
View reviewed changes
src/main/java/edu/hm/hafner/analysis/parser/checkstyle/CheckStyleParser.java
@@ -24,7 +24,7 @@
private static final long serialVersionUID = -3187275729854832128L;

@Override
public Report parse(final ReaderFactory readerFactory) throws ParsingException {
public Report parseReport(final ReaderFactory readerFactory) throws ParsingException {

Check warning

Code scanning / Jenkins Security Scan

Jenkins: Potentially unsafe classes Warning

This use of class
org.apache.commons.digester3.Digester
Loading
should be reviewed for unsafe behavior, like allowing XML External Entity injection, or arbitrary code execution.
src/main/java/edu/hm/hafner/analysis/parser/dry/AbstractDryParser.java
@@ -67,7 +67,7 @@
}

@Override
public Report parse(final ReaderFactory readerFactory) throws ParsingCanceledException, ParsingException {
public Report parseReport(final ReaderFactory readerFactory) throws ParsingCanceledException, ParsingException {

Check warning

Code scanning / Jenkins Security Scan

Jenkins: Potentially unsafe classes Warning

This use of class
org.apache.commons.digester3.Digester
Loading
should be reviewed for unsafe behavior, like allowing XML External Entity injection, or arbitrary code execution.
@github-actions GitHub Actions
Copy link

☀️   Quality Monitor

   🚦   Tests: 100% successful (❌ 2 failed, ✔️ 1292 passed, 🙈 2 skipped)
   〰️   Line Coverage: 93% (433 missed lines)
   ➰   Branch Coverage: 87% (272 missed branches)
   CheckStyle   CheckStyle: 2 warnings (normal: 2)
   PMD   PMD: No warnings
   SpotBugs   SpotBugs: 1 bug (low: 1)
   🐛   Error Prone: 27 bugs (normal: 27)
   OWASP Dependency Check   OWASP Dependency Check: 1 vulnerability (normal: 1)
   🌀   Cyclomatic Complexity: 2316 (total)
   💭   Cognitive Complexity: 1135 (total)
   📏   Lines of Code: 21867 (total)
   📝   Non Commenting Source Statements: 8764 (total)
   🔭   Access to foreign data: 1375 (total)
   🔗   Class cohesion: 100.00% (maximum)
   📤   Fan out: 3039 (total)
   📲   Number of accessors: 174 (total)
   ⚖️   Weight of a class: 100.00% (maximum)
   📐   Weighted method count: 2677 (total)
   ➿   N-Path Complexity: 3792 (total)

Created by Quality Monitor v1.14.0 (#f3859fd). More details are shown in the GitHub Checks Result.

@uhafner uhafner mentioned this pull request Dec 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking Breaking Changes enhancement Enhancement of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@uhafner