Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkins 56214 #142

Merged
merged 5 commits into from
Apr 2, 2019
Merged

Jenkins 56214 #142

merged 5 commits into from
Apr 2, 2019

Conversation

TanjaRo1
Copy link
Contributor

@TanjaRo1 TanjaRo1 commented Apr 2, 2019

Fixed PHP CodeSniffer errors treated as warnings:
Changed severity mapping of CheckStyleParser

@codecov
Copy link

codecov bot commented Apr 2, 2019

Codecov Report

Merging #142 into master will decrease coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #142      +/-   ##
============================================
- Coverage     87.89%   87.81%   -0.08%     
+ Complexity     1211     1209       -2     
============================================
  Files           157      157              
  Lines          3865     3865              
  Branches        424      424              
============================================
- Hits           3397     3394       -3     
- Misses          311      315       +4     
+ Partials        157      156       -1
Impacted Files Coverage Δ Complexity Δ
...r/analysis/parser/checkstyle/CheckStyleParser.java 76.59% <100%> (-6.39%) 10 <0> (-2)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dea934...c149dcb. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 2, 2019

Codecov Report

Merging #142 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #142      +/-   ##
============================================
+ Coverage     87.89%   87.95%   +0.06%     
- Complexity     1211     1218       +7     
============================================
  Files           157      158       +1     
  Lines          3865     3911      +46     
  Branches        424      427       +3     
============================================
+ Hits           3397     3440      +43     
- Misses          311      315       +4     
+ Partials        157      156       -1
Impacted Files Coverage Δ Complexity Δ
...r/analysis/parser/checkstyle/CheckStyleParser.java 76.59% <100%> (-6.39%) 10 <0> (-2)
...du/hm/hafner/analysis/parser/CargoCheckParser.java 100% <0%> (ø) 9% <0%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dea934...759421c. Read the comment docs.

Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! There are some minor coding style issues (see https://app.codacy.com/app/uhafner/analysis-model/pullRequest?prid=3366165). Each comment needs to be ended with a period, and underscores in method names.

Remove unused comments + refactor CheckStyleParse
Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry: the method that needs to be removed is mapPriority.

@uhafner uhafner merged commit 8d53cf2 into jenkinsci:master Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants