-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jenkins 56214 #142
Jenkins 56214 #142
Conversation
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
============================================
- Coverage 87.89% 87.81% -0.08%
+ Complexity 1211 1209 -2
============================================
Files 157 157
Lines 3865 3865
Branches 424 424
============================================
- Hits 3397 3394 -3
- Misses 311 315 +4
+ Partials 157 156 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
============================================
+ Coverage 87.89% 87.95% +0.06%
- Complexity 1211 1218 +7
============================================
Files 157 158 +1
Lines 3865 3911 +46
Branches 424 427 +3
============================================
+ Hits 3397 3440 +43
- Misses 311 315 +4
+ Partials 157 156 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! There are some minor coding style issues (see https://app.codacy.com/app/uhafner/analysis-model/pullRequest?prid=3366165). Each comment needs to be ended with a period, and underscores in method names.
src/main/java/edu/hm/hafner/analysis/parser/checkstyle/CheckStyleParser.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/hm/hafner/analysis/parser/checkstyle/CheckStyleParser.java
Show resolved
Hide resolved
src/test/java/edu/hm/hafner/analysis/parser/CheckStyleParserTest.java
Outdated
Show resolved
Hide resolved
Remove unused comments + refactor CheckStyleParse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry: the method that needs to be removed is mapPriority
.
Fixed PHP CodeSniffer errors treated as warnings:
Changed severity mapping of CheckStyleParser