Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkins 52462: SonarQubeParser should read textRange #155

Merged
merged 5 commits into from
Apr 12, 2019

Conversation

RedTo
Copy link
Contributor

@RedTo RedTo commented Apr 10, 2019

Fixed: https://issues.jenkins-ci.org/browse/JENKINS-52462

  • Added parseEnd method and use textRange.
  • Changed parseStart to abstract and implemented in both parsers.
  • Fixed tests
  • Increased version number and added info to changelog

@codecov
Copy link

codecov bot commented Apr 10, 2019

Codecov Report

Merging #155 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #155      +/-   ##
============================================
+ Coverage     88.47%   88.51%   +0.04%     
- Complexity     1230     1235       +5     
============================================
  Files           158      158              
  Lines          3922     3937      +15     
  Branches        424      424              
============================================
+ Hits           3470     3485      +15     
  Misses          296      296              
  Partials        156      156
Impacted Files Coverage Δ Complexity Δ
...edu/hm/hafner/analysis/parser/SonarQubeParser.java 75.36% <100%> (ø) 23 <0> (-1) ⬇️
.../hafner/analysis/parser/SonarQubeIssuesParser.java 100% <100%> (ø) 7 <4> (+4) ⬆️
...hm/hafner/analysis/parser/SonarQubeDiffParser.java 100% <100%> (ø) 7 <2> (+2) ⬆️
...ain/java/edu/hm/hafner/analysis/ReaderFactory.java 72.91% <0%> (+4.62%) 11% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2b822e...d8f7555. Read the comment docs.

@RedTo
Copy link
Contributor Author

RedTo commented Apr 11, 2019

During implementation I found some minor errors:

  • old implementation just founds 31 instead of 32 errors (fixed)
  • compiler claimed, that SonarQubeParser parserModulePath should be package-private instead of protected
  • typo in SonarQubeParser createIssueFormJsonObject -> createIssueFromJsonObject (I guess I can correct it, because it is a private method. Can and should I?)

CHANGELOG.md Outdated Show resolved Hide resolved
@uhafner
Copy link
Member

uhafner commented Apr 11, 2019

Yes, please rename the private method.

@uhafner uhafner merged commit 4b962f3 into jenkinsci:master Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants