-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jenkins 52462: SonarQubeParser should read textRange #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added parseEnd override both in diffParser and issuesParsers fixed test to find all issues
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
============================================
+ Coverage 88.47% 88.51% +0.04%
- Complexity 1230 1235 +5
============================================
Files 158 158
Lines 3922 3937 +15
Branches 424 424
============================================
+ Hits 3470 3485 +15
Misses 296 296
Partials 156 156
Continue to review full report at Codecov.
|
During implementation I found some minor errors:
|
uhafner
requested changes
Apr 11, 2019
src/test/java/edu/hm/hafner/analysis/parser/SonarQubeIssuesParserTest.java
Outdated
Show resolved
Hide resolved
Yes, please rename the private method. |
check for duplicates(0) on isses present test
uhafner
approved these changes
Apr 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: https://issues.jenkins-ci.org/browse/JENKINS-52462