-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update httpcore.version to v5.3.1 #61
Conversation
Rather recommend reverting recent updates until an upstream ticket is filed as described in #59 (comment). |
I’m almost certain the issues we are seeing must rather be fixed in the downstream projects. At least that’s what my first impression was looking closer at the issue with docker-plugin / docker-java. Unfortunately my time for in-depth investigations is very limited right now 😔 |
Then they need to be reported to the upstream projects. The status quo, wherein we do not take action upstream but continue to deliver the problematic release in the Update Center, results in pain for operators and end users. |
There exist issues / PRs in both, docker-plugin and docker-java projects such as jenkinsci/docker-plugin#1103 None of which has been addressed by a maintainer from what I can tell. I agree that the current situation is unfortunate for end users but I don’t really see how not providing updates of this plugin would make it worse. Chances are that an update may even fix the issue as it was the case ~ half a year ago in docker-java/docker-java#2262 |
Not upstream issues and therefore not likely to result in action. A closed issue and therefore not likely to result in action. Unclear how these PRs would address the symptoms that are affecting Jenkins users, if merged and released. The most likely scenario for action to be taken is for a clear issue to be filed upstream with steps to reproduce, expected results, and actual results. See for example a recent issue I filed against upstream Jetty for JENKINS-73942. |
Again, I am very confident that it’s the downstream projects that must take action. I don’t really understand why you think that this will not help solving the issue and insist that it must be upstream instead, but let’s not argue. So far I was unable to find anything that could work as a MRE. Neither could I find possible culprits in the changes for httpclient - however the changeset is quite large and there is still plenty to check. |
I am not insisting that it is upstream instead. If the problem is downstream, where is the PR to patch |
I must have gotten that wrong then, sorry.
Not sure what you mean by that. Patching as in finding a fix? I was looking into it but as I already mentioned my time is very limited right now. |
That is completely understandable. In that case, we need to revert the library upgrade that exposed this problem in order to restore the status quo of working software to our end users. |
This PR contains the following updates:
5.3
->5.3.1
5.3
->5.3.1
5.3
->5.3.1
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.