Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update httpcore.version to v5.3.1 #61

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 22, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.apache.httpcomponents.core5:httpcore5-reactive 5.3 -> 5.3.1 age adoption passing confidence
org.apache.httpcomponents.core5:httpcore5-h2 5.3 -> 5.3.1 age adoption passing confidence
org.apache.httpcomponents.core5:httpcore5 5.3 -> 5.3.1 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner October 22, 2024 13:43
@renovate renovate bot added the dependencies Pull requests that update a dependency file label Oct 22, 2024
@renovate renovate bot enabled auto-merge (rebase) October 22, 2024 13:43
@renovate renovate bot merged commit 6b5b322 into main Oct 22, 2024
17 checks passed
@renovate renovate bot deleted the renovate/httpcore.version branch October 22, 2024 13:47
@strangelookingnerd strangelookingnerd added the enhancement New feature or request label Oct 22, 2024
@basil
Copy link
Member

basil commented Oct 22, 2024

Rather recommend reverting recent updates until an upstream ticket is filed as described in #59 (comment).

@strangelookingnerd
Copy link
Contributor

Rather recommend reverting recent updates until an upstream ticket is filed as described in #59 (comment).

I’m almost certain the issues we are seeing must rather be fixed in the downstream projects. At least that’s what my first impression was looking closer at the issue with docker-plugin / docker-java. Unfortunately my time for in-depth investigations is very limited right now 😔

@basil
Copy link
Member

basil commented Oct 22, 2024

I’m almost certain the issues we are seeing must rather be fixed in the downstream projects.

Then they need to be reported to the upstream projects. The status quo, wherein we do not take action upstream but continue to deliver the problematic release in the Update Center, results in pain for operators and end users.

@strangelookingnerd
Copy link
Contributor

There exist issues / PRs in both, docker-plugin and docker-java projects such as

jenkinsci/docker-plugin#1103
jenkinsci/docker-plugin#1087
docker-java/docker-java#2307
docker-java/docker-java#2272
docker-java/docker-java#2293

None of which has been addressed by a maintainer from what I can tell. I agree that the current situation is unfortunate for end users but I don’t really see how not providing updates of this plugin would make it worse. Chances are that an update may even fix the issue as it was the case ~ half a year ago in docker-java/docker-java#2262

@basil
Copy link
Member

basil commented Oct 22, 2024

jenkinsci/docker-plugin#1103
jenkinsci/docker-plugin#1087

Not upstream issues and therefore not likely to result in action.

docker-java/docker-java#2307

A closed issue and therefore not likely to result in action.

docker-java/docker-java#2272
docker-java/docker-java#2293

Unclear how these PRs would address the symptoms that are affecting Jenkins users, if merged and released.

The most likely scenario for action to be taken is for a clear issue to be filed upstream with steps to reproduce, expected results, and actual results. See for example a recent issue I filed against upstream Jetty for JENKINS-73942.

@strangelookingnerd
Copy link
Contributor

I’m almost certain the issues we are seeing must rather be fixed in the downstream projects.

Again, I am very confident that it’s the downstream projects that must take action. I don’t really understand why you think that this will not help solving the issue and insist that it must be upstream instead, but let’s not argue. So far I was unable to find anything that could work as a MRE. Neither could I find possible culprits in the changes for httpclient - however the changeset is quite large and there is still plenty to check.

@basil
Copy link
Member

basil commented Oct 22, 2024

I am not insisting that it is upstream instead. If the problem is downstream, where is the PR to patch docker-plugin?

@strangelookingnerd
Copy link
Contributor

I am not insisting that it is upstream instead.

Not upstream issues and therefore not likely to result in action.

I must have gotten that wrong then, sorry.

If the problem is downstream, where is the PR to patch docker-plugin?

Not sure what you mean by that. Patching as in finding a fix? I was looking into it but as I already mentioned my time is very limited right now.

@basil
Copy link
Member

basil commented Oct 22, 2024

I was looking into it but as I already mentioned my time is very limited right now.

That is completely understandable. In that case, we need to revert the library upgrade that exposed this problem in order to restore the status quo of working software to our end users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants