Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup for Jenkins 2.387.3 #401

Merged
merged 15 commits into from
Oct 19, 2023
Merged

Cleanup for Jenkins 2.387.3 #401

merged 15 commits into from
Oct 19, 2023

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Oct 17, 2023

Update plugin and dependencies to Jenkins 2.387.3. Use new coverage model of code coverage plugin. Fix broken UI problems due to Bootstrap 5 migration.

Additional cleanup:

  • Replace @Generated from the Jakarta package with my own version of @Generated in AssertJ generated code.
  • Update CI actions to use Java 17 and 21 with Maven 3.9.5.

Bildschirmfoto 2023-10-18 um 14 52 21
Bildschirmfoto 2023-10-18 um 14 53 00

@uhafner uhafner added enhancement Enhancement of existing functionality breaking Breaking Changes labels Oct 17, 2023
@uhafner uhafner removed the enhancement Enhancement of existing functionality label Oct 19, 2023
*/
@SuppressWarnings("unused") // Called by jelly view
@CheckForNull
public Object getDynamic(final String link, final StaplerRequest request, final StaplerResponse response) {

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'request' is never used.
*/
@SuppressWarnings("unused") // Called by jelly view
@CheckForNull
public Object getDynamic(final String link, final StaplerRequest request, final StaplerResponse response) {

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'response' is never used.
@@ -18,7 +18,7 @@
*
* @author Ullrich Hafner
*/
class AggregatedScoreXmlStreamTest extends SerializableTest<AggregatedScore> {
class AggregatedScoreXmlStreamITest extends SerializableTest<AggregatedScore> {

Check notice

Code scanning / CodeQL

Unused classes and interfaces Note test

Unused class: AggregatedScoreXmlStreamITest is not referenced within this codebase. If not used as an external API it should be removed.
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@dac4e88). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #401   +/-   ##
=======================================
  Coverage        ?   92.41%           
  Complexity      ?       30           
=======================================
  Files           ?        7           
  Lines           ?      145           
  Branches        ?       10           
=======================================
  Hits            ?      134           
  Misses          ?        5           
  Partials        ?        6           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@uhafner uhafner added the enhancement Enhancement of existing functionality label Oct 19, 2023
@uhafner uhafner merged commit ff43868 into main Oct 19, 2023
30 of 31 checks passed
@uhafner uhafner deleted the cleanup branch October 19, 2023 15:18
@uhafner uhafner changed the title Cleanup Cleanup for Jenkins 2.387.3 Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking Changes enhancement Enhancement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant