Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some failing ATH tests, increase some timeout to avoid flakyness of some tests #2495

Merged
merged 22 commits into from
Sep 16, 2023
Merged

Fix some failing ATH tests, increase some timeout to avoid flakyness of some tests #2495

merged 22 commits into from
Sep 16, 2023

Conversation

olamy
Copy link
Member

@olamy olamy commented Sep 12, 2023

Signed-off-by: Olivier Lamy olamy@apache.org

Description

See JENKINS-XXXXX.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Appropriate unit or acceptance tests or explanation to why this change has no tests
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

@olamy
add an option to disable flaky tests on CI
ae1df5c 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
re run tests
d4b365a 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
add some retry
da0c10c 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
this re run here is a bad idea :)
dbdfdee 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
more retry
0cf4a61 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
reduce timeout
bfe70bd 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
need this new option now to have some tests working -Dhudson.plugins.…
2e8ea60 
…git.GitSCM.ALLOW_LOCAL_CHECKOUT=true

Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
test with forkCount 2
19c7b04 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
fix some XPath
01d7780 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
default retry of 3 for ATH tests
fbeb4ad 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
forkCount 3
6154b44 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
less agressive with the build :)
39c04ab 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
increase timeout here
f2de7dd 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
increase timeout here
20c8a0e 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
a bit more memory
722efc8 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
increase even more ATH default timeout
ca9dceb 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
disable this one as it is too much flaky
8912640 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
use default wait timeout
0c5e2dd 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
use default wait timeout
6474e7b 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
fix pom
53707a6 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy olamy changed the title add an option to disable flaky tests on CI Fix some failing ATH test, increase some timeout to avoid flakyness of some tests Sep 15, 2023
@olamy
fix pom
36aaeb4 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy olamy marked this pull request as ready for review September 16, 2023 09:25
@olamy olamy requested a review from a team as a code owner September 16, 2023 09:25
@olamy olamy added the chore label Sep 16, 2023
@olamy olamy changed the title Fix some failing ATH test, increase some timeout to avoid flakyness of some tests Fix some failing ATH tests, increase some timeout to avoid flakyness of some tests Sep 16, 2023
@olamy
use max of retry and default retry
bf8411c 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy olamy merged commit 76bc08e into master Sep 16, 2023
1 of 3 checks passed
@olamy olamy deleted the disable-flaky-ath-tests-on-ci branch September 16, 2023 23:15
jglick
jglick reviewed Sep 22, 2023
View reviewed changes
...est/java/io/jenkins/blueocean/blueocean_github_pipeline/GithubPipelineCreateRequestTest.java
@@ -368,6 +365,7 @@ public void shouldFindUserStoreCredential() throws Exception {
}

@Test
@Ignore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that #2503 may have helped, but the test was dubious to begin with. In fact CloudBees is experimenting with disabling Internet access during PCT runs, to reduce flakiness, which I think would cause this test to hang.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick left review comments

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olamy @jglick