-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 2.462.x release line, remove 2.426.x #3374
Conversation
Remove workflow-cps-plugin workaround Fixes jenkinsci#3301
As recommended by "choosing a Jenkins version" and past practice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you forget to update
Line 20 in 2dd9d95
<artifactId>bom-weekly</artifactId> |
Thanks to @jglick for detecting that mistake. Reported as jenkinsci#3374 (review)
Passing now @MarkEWaite; did you plan to merge & release? |
Thanks for asking. I thought that we'd run the weekly release tomorrow without this change and then merge it and release it at the end of next week. The first release candidate of 2.462.1 will be available Wednesday then the first BOM release with the 2.462.x profile will be available on Friday or Saturday. Let me know if there is a specific benefit to merging sooner. I'm happy to merge sooner, but didn't want to drop the 2.426.x line until after the 2.462.1 RC was available. |
I'm intentionally leaving the conflict in this pull request until the next time that I want to perform a full test of the latest changes on the master branch. |
Easier for me to find those old versions in the README rather than searching the releases list for comments that tell me when a line was dropped.
I've resolved the conflict to test the merge of the ssh-credentials 342.x release that arrived in: Full test has started and should confirm that change is passing tests. Before submitting the most recent change, I confirmed passing results for: $ mvn clean verify
$ PLUGINS=ssh-credentials TEST=InjectedTest bash local-test.sh Once full tests pass, I plan to merge this. Tests failed due to a test dependency issue exposed by ssh-credentials update to most recent parent pom and the inclusion of an updated trilead API optional dependency. After reverting ssh-credentials, was able to try again. |
Add 2.462.x line, remove 2.426.x line
Fixes #3301
Testing done
Confirmed that
mvn clean verify
andPLUGINS=structs,mailer TEST=InjectedTest bash local-test.sh
pass locally.Submitter checklist