Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make a comment more inclusive #314

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make a comment more inclusive #314

wants to merge 1 commit into from

Conversation

Ladyprowess
Copy link

Rather than "master" use "controller"

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
    Ensure you have provided tests - that demonstrate the feature works or fixes the issue

@Ladyprowess
Make a comment more inclusive
a59ee74 
Rather than "master" use "controller"
@car-roll car-roll enabled auto-merge (squash) November 10, 2022 01:30
jglick
jglick requested changes Dec 15, 2022
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway this pre-Release Drafter file should go away.

CHANGELOG.md
@@ -615,7 +615,7 @@ immediately” after the upgrade.
([Pipeline Plugin](https://wiki.jenkins.io/display/JENKINS/Pipeline+Plugin)).
- Major refactoring to use `ComputedFolder` API in
[CloudBees Folders Plugin](https://wiki.jenkins.io/display/JENKINS/CloudBees+Folders+Plugin).
- Always run branch indexing on the master node.
- Always run branch indexing on the controller node.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Always run branch indexing on the controller node.
- Always run branch indexing on the built-in node.

@jglick jglick mentioned this pull request Dec 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick requested changes

@car-roll car-roll car-roll approved these changes

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ladyprowess @jglick @MarkEWaite @car-roll