Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks for queue item #1

Merged
merged 5 commits into from
Aug 1, 2020
Merged

Checks for queue item #1

merged 5 commits into from
Aug 1, 2020

Conversation

XiongKezhi
Copy link
Contributor

Will add the implementation in the GitHub Checks plugin later.

@XiongKezhi
Copy link
Contributor Author

I'll later push some changes on master to suppress "hidden field" checkstyle warning and merge it here to pass the CI.

@XiongKezhi XiongKezhi requested review from timja and uhafner July 31, 2020 08:33
@timja
Copy link
Member

timja commented Jul 31, 2020

I would like to see the github side of this as I don't really understand what this is for.
Or at least some more description

@XiongKezhi
Copy link
Contributor Author

Sorry, I should add the context.

Before this, when we publish the "queued" checks for the main build, we extend the RunListener and override the onInitialize method, but it looks like that onInitialize is triggered after the job leaves the queue and when initializing the run. Therefore, to let the "queued" checks be published when a job actually enters the queue, we have to extend another listener which is QueueListener and override the onEntersQueue method.

I added the method fromItem because I found that the Item for queue is not compatible with Run.

@timja

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once checkstyle is sorted

@XiongKezhi XiongKezhi merged commit 6d4656b into master Aug 1, 2020
@XiongKezhi XiongKezhi deleted the checks-for-queue-item branch August 1, 2020 03:43
@XiongKezhi XiongKezhi added the enhancement New feature or request label Aug 1, 2020
XiongKezhi added a commit that referenced this pull request Oct 25, 2020
Using installaion event and Branch Source SCM done!
XiongKezhi pushed a commit that referenced this pull request Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants