-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checks for queue item #1
Conversation
I'll later push some changes on master to suppress "hidden field" checkstyle warning and merge it here to pass the CI. |
I would like to see the github side of this as I don't really understand what this is for. |
Sorry, I should add the context. Before this, when we publish the "queued" checks for the main build, we extend the RunListener and override the onInitialize method, but it looks like that onInitialize is triggered after the job leaves the queue and when initializing the run. Therefore, to let the "queued" checks be published when a job actually enters the queue, we have to extend another listener which is QueueListener and override the onEntersQueue method. I added the method fromItem because I found that the Item for queue is not compatible with Run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm once checkstyle is sorted
Using installaion event and Branch Source SCM done!
Will add the implementation in the GitHub Checks plugin later.