Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the old "fromRun" method which does not take listener as parameter #25

Merged
merged 1 commit into from
Sep 3, 2020
Merged

Remove the old "fromRun" method which does not take listener as parameter #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions src/main/java/io/jenkins/plugins/checks/api/ChecksPublisherFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import java.util.Optional;

import edu.hm.hafner.util.VisibleForTesting;
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import hudson.model.Job;
import hudson.model.Run;
import hudson.model.TaskListener;
Expand Down Expand Up @@ -60,18 +59,6 @@ protected Optional<ChecksPublisher> createPublisher(final Job<?, ?> job, final T
return Optional.empty();
}

/**
* Returns a suitable publisher for the run.
*
* @param run
* a Jenkins run
* @return a publisher suitable for the job
*/
@SuppressFBWarnings(value = "NP_NONNULL_PARAM_VIOLATION", justification = "restore to 0.1.0 version api")
public static ChecksPublisher fromRun(final Run<?, ?> run) {
return fromRun(run, null, new JenkinsFacade());
}

/**
* Returns a suitable publisher for the run.
*
Expand Down