Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove beta restrictions #30

Merged
merged 2 commits into from
Sep 25, 2020
Merged

Remove beta restrictions #30

merged 2 commits into from
Sep 25, 2020

Conversation

XiongKezhi
Copy link
Contributor

No description provided.

@XiongKezhi XiongKezhi requested a review from a team September 23, 2020 13:42
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@timja
Copy link
Member

timja commented Sep 23, 2020

Looks like you need to adjust rev-api config or bump a semver version.

@XiongKezhi
Copy link
Contributor Author

Looks like you need to adjust rev-api config or bump a semver version.

Yes, I'll adjust the config, or we'll have to update to 2.0.0 which I think is bad since we haven't done many things.

@timja
Copy link
Member

timja commented Sep 23, 2020

Looks like you need to adjust rev-api config or bump a semver version.

Yes, I'll adjust the config, or we'll have to update to 2.0.0 which I think is bad since we haven't done many things.

not worth imo just do the config 😄

Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is an example for some exclusions:
https://github.com/jenkinsci/warnings-ng-plugin/blob/master/plugin/pom.xml#L596

Typically, removing or adding annotations (at least those) does not harm

@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #30 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #30   +/-   ##
=========================================
  Coverage     91.20%   91.20%           
  Complexity       69       69           
=========================================
  Files            11       11           
  Lines           273      273           
  Branches          6        6           
=========================================
  Hits            249      249           
  Misses           22       22           
  Partials          2        2           
Impacted Files Coverage Δ Complexity Δ
...va/io/jenkins/plugins/checks/api/ChecksAction.java 100.00% <ø> (ø) 5.00 <0.00> (ø)
...o/jenkins/plugins/checks/api/ChecksAnnotation.java 100.00% <ø> (ø) 12.00 <0.00> (ø)
...o/jenkins/plugins/checks/api/ChecksConclusion.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...a/io/jenkins/plugins/checks/api/ChecksDetails.java 100.00% <ø> (ø) 10.00 <0.00> (ø)
...ava/io/jenkins/plugins/checks/api/ChecksImage.java 90.00% <ø> (ø) 5.00 <0.00> (ø)
...va/io/jenkins/plugins/checks/api/ChecksOutput.java 100.00% <ø> (ø) 8.00 <0.00> (ø)
...io/jenkins/plugins/checks/api/ChecksPublisher.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...va/io/jenkins/plugins/checks/api/ChecksStatus.java 100.00% <ø> (ø) 1.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 536774b...e360644. Read the comment docs.

@XiongKezhi XiongKezhi merged commit 4456c01 into master Sep 25, 2020
@XiongKezhi XiongKezhi deleted the remove-beta-restriction branch September 25, 2020 15:36
@timja timja added the chore label Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants