Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

Use the coverages that are persisted within the action if possible #423

Merged
merged 4 commits into from
Jul 10, 2022

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Jul 10, 2022

Otherwise, the whole coverage result XML will be loaded just for a single value.

Will fix jenkins-infra/helpdesk#3029.

@uhafner uhafner added the bug Bugs or performance problems label Jul 10, 2022
@codecov
Copy link

codecov bot commented Jul 10, 2022

Codecov Report

Merging #423 (de934ea) into master (9241b76) will increase coverage by 0.09%.
The diff coverage is 81.25%.

@@             Coverage Diff              @@
##             master     #423      +/-   ##
============================================
+ Coverage     72.08%   72.18%   +0.09%     
- Complexity      984      992       +8     
============================================
  Files            86       86              
  Lines          3694     3700       +6     
  Branches        431      433       +2     
============================================
+ Hits           2663     2671       +8     
+ Misses          885      883       -2     
  Partials        146      146              
Impacted Files Coverage Δ
...ns/plugins/coverage/model/CoverageBuildAction.java 78.72% <80.00%> (+3.72%) ⬆️
...nkins/plugins/coverage/model/CoverageReporter.java 81.60% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9241b76...de934ea. Read the comment docs.

Otherwise, the whole coverage result XML will be loaded just for a single value.
See jenkins-infra/helpdesk#3029 for details.
@uhafner uhafner force-pushed the use-action-values branch from b785785 to 1db93ae Compare July 10, 2022 14:21
@uhafner uhafner merged commit 4bda86e into master Jul 10, 2022
@uhafner uhafner deleted the use-action-values branch July 10, 2022 21:43
@medianick
Copy link
Contributor

Thanks @uhafner! I look forward to trying this fix. As I noted on the linked issue, our PR pages for multibranch pipeline jobs started taking over a minute to render a list of 100 PRs. We hadn't yet tracked down the cause but it coincided with the initial upgrade to 3.0.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bugs or performance problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

502 proxy error when accessing PR view for jenkinsci/jenkins
2 participants