Adding else and if-else support #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SanjayThomas sorry for missing this, I will take a look a it as soon as I find time |
Pulling in upstream changes
|
The earlier failure was due to the test case trying to open a Unix shell while testing in WIndows. Modified the test case to use BatchFile when running on Windows. |
|
@imod Could you take a look at this? Please let me know if I've missed something here. |
|
I am tempted to land it, but I would like to firstly integrate #21 which is quite an emergency for the new weekly releases |
|
@oleg-nenashev please feel free to do so - I'm currently very short in time and will not be able to do so in any foreseeable time |
|
This PR will need an update after the recent tables to divs patches. Added to my queue, no ETA :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello All,
I had seen the ER for enabling else support for the conditional builds step plugin:
https://issues.jenkins-ci.org/browse/JENKINS-20292?src=confmacro
I have also added if-else support as part of the ER as I had seen this request in a duplicate ER of the above-mentioned one. Link to this:
https://issues.jenkins-ci.org/browse/JENKINS-25918
Hope this implementation is satisfactory.