Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changelog formatting #38

Merged
merged 5 commits into from
Sep 12, 2022
Merged

Fix changelog formatting #38

merged 5 commits into from
Sep 12, 2022

Conversation

MarkEWaite
Copy link
Contributor

Fix presentation of the changelog on GitHub by removing broken markup.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@MarkEWaite MarkEWaite disabled auto-merge September 12, 2022 20:29
@MarkEWaite MarkEWaite enabled auto-merge (squash) September 12, 2022 20:29
@MarkEWaite
Copy link
Contributor Author

@jmMeessen and @gounthar this one needs to be merged because it is not a step in the tutorial and I'd rather not have the legacy changelog be so hard to read

Copy link
Contributor

@gounthar gounthar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Looks good to me.

@MarkEWaite MarkEWaite merged commit 7a2efbd into jenkinsci:master Sep 12, 2022
@MarkEWaite MarkEWaite deleted the fix-changelog-formatting branch September 12, 2022 20:39
MarkEWaite added a commit to MarkEWaite/repository-permissions-updater that referenced this pull request Aug 5, 2023
I've contributed several pull requests to the plugin, including:

* jenkinsci/conditional-buildstep-plugin#46
* jenkinsci/conditional-buildstep-plugin#47
* jenkinsci/conditional-buildstep-plugin#38
* jenkinsci/conditional-buildstep-plugin#48
* jenkinsci/conditional-buildstep-plugin#45
* jenkinsci/conditional-buildstep-plugin#44

I already have permission on the GitHub repository and have merged
several pull requests.

I'd like release permissions so that the plugin can be built and a new
release can be included in the plugin bill of materials.  Plugin BOM
pull request is:

* jenkinsci/bom#2224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants