chore: Parallelize Tests #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will use all available cores to run tests, and parallelize by all - suite/class/method. On machines with multiple cores, this will vastly improve test performance. These times are on my M1 MBP with 10 (8P + 2E) cores. They were reported by maven on running `mvn verify`. I first ran `mvn verify` and ignored the time. Then I ran it thrice without this change, and thrice with this change. All times in seconds. | | Run 1 | Run 2 | Run 3 | Average | | ------ | ----: | ----: | ----: | ------: | | Before | 21 | 21 | 22 | 21 | | After | 16 | 16 | 16 | 16 | | Savings| | | | 5 | | % | | | | 24 |
Forcing the forkCount setting in the plugin pom will override the value that a developer might set on their local computer based on the configuration of that computer. The configuration on ci.jenkins.io is known to have enough memory for a JVM per core. Use JVM per core on ci.jenkins.io for faster testing and reduced costs.
MarkEWaite
approved these changes
Aug 5, 2023
There was a problem hiding this comment.
Thanks for the idea to run tests in parallel. Implementation has changed based on recommendation from @jtnord.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will use all available cores to run tests, and parallelize by all - suite/class/method. On machines with multiple cores, this will vastly improve test performance. These times are on my M1 MBP with 10 (8P + 2E) cores. They were reported by maven on running
mvn verify.I first ran
mvn verifyand ignored the time.Then I ran it thrice without this change, and thrice with this change.
All times in seconds.
Testing done
All existing tests pass
Submitter checklist