Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Crowd2 demo and integration test - suspended plugin #2433

Merged

Conversation

MarkEWaite
Copy link
Contributor

Remove Crowd2 demo and integration test - suspended plugin

jenkins-infra/helpdesk#3854 notes that the Crowd2 plugin uses one or more closed source dependencies. Those dependencies make it ineligible to be distributed by the Jenkins update center. Let's remove the integration test and documentation so that we are not describing the configuration of a suspended plugin.

jenkins-infra/helpdesk#3842 (comment) describes the case where we detected the closed source dependency through the configuration as code plugin integration test of the Crowd2 plugin. Unless we include the Atlassian closed source repository, the configuration as code plugin fails to compile its integration tests.

jenkins-infra/helpdesk#3842 (comment) provides additional details from the investigation related to the Jenkins artifact repository and its caches.

jenkins-infra/helpdesk#3842 (comment) summarizes my investigation

Your checklist for this pull request

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or in Jenkins JIRA
  • Link to relevant pull requests, esp. upstream and downstream changes

jenkins-infra/helpdesk#3854 notes that
the Crowd2 plugin uses one or more closed source dependencies.
Those dependencies make it ineligible to be distributed by the Jenkins
update center.  Let's remove the integration test and documentation so
that we are not describing the configuration of a suspended plugin.

jenkins-infra/helpdesk#3842 (comment)
describes the case where we detected the closed source dependency
through the configuration as code plugin integration test of the Crowd2
plugin.  Unless we include the Atlassian closed source repository,
the configuration as code plugin fails to compile its integration tests.

jenkins-infra/helpdesk#3842 (comment)
provides additional details from the investigation related to the Jenkins
artifact repository and its caches.

jenkins-infra/helpdesk#3842 (comment)
summarizes my investigation
@MarkEWaite MarkEWaite requested a review from a team as a code owner December 9, 2023 14:30
@timja timja added the developer label Dec 9, 2023
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, releasing it in case it impacts PCT

@timja timja merged commit c96b848 into jenkinsci:master Dec 9, 2023
16 checks passed
@MarkEWaite MarkEWaite deleted the remove-crowd2-integration-test-and-docs branch December 9, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants