Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CoberturaParser more robost on broken input files #39

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Oct 11, 2023

Add a new optional property to the parser to ignore all errors. Additionally, use a default value of 2/2 when branch coverage is missing the details attribute condition-coverage.

See jenkinsci/code-coverage-api-plugin#785

Add a new optional property to the parser to ignore all errors.
Additionally, use a default value of 2/2 when branch coverage
is missing the details.

See jenkinsci/code-coverage-api-plugin#785
@uhafner uhafner added the bug Bugs or performance problems label Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #39 (a654daa) into main (95b35ab) will increase coverage by 0.28%.
Report is 6 commits behind head on main.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main      #39      +/-   ##
============================================
+ Coverage     95.07%   95.36%   +0.28%     
- Complexity      578      600      +22     
============================================
  Files            23       23              
  Lines          1402     1466      +64     
  Branches        201      207       +6     
============================================
+ Hits           1333     1398      +65     
+ Misses           44       42       -2     
- Partials         25       26       +1     
Files Coverage Δ
...in/java/edu/hm/hafner/coverage/CoverageParser.java 79.31% <100.00%> (+7.88%) ⬆️
src/main/java/edu/hm/hafner/coverage/Node.java 98.58% <100.00%> (+2.25%) ⬆️
...edu/hm/hafner/coverage/parser/CoberturaParser.java 89.92% <100.00%> (+0.66%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@uhafner uhafner merged commit 8438be4 into main Oct 11, 2023
33 checks passed
@uhafner uhafner deleted the cobertura-ignore-errors branch October 11, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant