draft: Add support for OpenCover format based on opencover plugin #46

jonesbusy · 2023-10-24T10:05:52Z

This is on on-going process to implement the opencover format to coverage-model

Only need to convert the parser from https://github.com/jenkinsci/opencover-plugin/blob/main/src/main/java/io/jenkins/plugins/opencover/OpenCoverReportAdapter.java#L37

Originally raised here on the deprecated code-coverage-api-plugin

Testing done

Submitter checklist

Give feedback

Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Ensure that the pull request title represents the desired changelog entry
Please describe what you did
Link to relevant issues in GitHub or Jira
Link to relevant pull requests, esp. upstream and downstream changes
Ensure you have provided tests - that demonstrates feature works or fixes the issue
Options

src/main/java/edu/hm/hafner/coverage/parser/OpenCoverParser.java

+    }
+
+    private void readPackage(final XMLEventReader reader, final ModuleNode root,
+            final StartElement currentStartElement, final FilteredLog log) throws XMLStreamException {


src/main/java/edu/hm/hafner/coverage/parser/OpenCoverParser.java

uhafner · 2023-11-17T21:40:23Z

Let me know if you need some help here. I created a similar PR for a new parser of JUnit results, see #53 for details.

jonesbusy · 2023-11-18T07:05:50Z

@uhafner Thanks probably just missing time. Also I'm not very familiar yet with the model

src/main/java/edu/hm/hafner/coverage/parser/OpenCoverParser.java

+    private void readFile(final XMLEventReader reader, final ModuleNode root,
+            final StartElement currentStartElement, final FilteredLog log) throws XMLStreamException {
+
+        PackageNode packageNode = null;


src/main/java/edu/hm/hafner/coverage/parser/OpenCoverParser.java

+            if (event.isStartElement()) {
+                var nextElement = event.asStartElement();
+                if (CLASS_NAME.equals(nextElement.getName())) {
+                    String className = reader.nextEvent().asCharacters().getData();


src/main/java/edu/hm/hafner/coverage/parser/OpenCoverParser.java

+        }
+    }
+
+    private Node createClassNode(final FileNode file, final StartElement parentElement) {


src/main/java/edu/hm/hafner/coverage/parser/OpenCoverParser.java

+        }
+    }
+
+    private void readClass(final XMLEventReader reader, final StartElement parentElement, final FilteredLog log) throws XMLStreamException {


src/main/java/edu/hm/hafner/coverage/parser/OpenCoverParser.java

+        }
+    }
+
+    private void readClass(final XMLEventReader reader, final StartElement parentElement, final FilteredLog log) throws XMLStreamException {


src/main/java/edu/hm/hafner/coverage/parser/OpenCoverParser.java

+    }
+
+    private void readFile(final XMLEventReader reader, final ModuleNode root,
+            final StartElement currentStartElement, final FilteredLog log) throws XMLStreamException {


src/main/java/edu/hm/hafner/coverage/parser/OpenCoverParser.java

+    }
+
+    private void readPackage(final XMLEventReader reader, final ModuleNode root,
+            final StartElement currentStartElement, final FilteredLog log) throws XMLStreamException {


src/main/java/edu/hm/hafner/coverage/parser/OpenCoverParser.java

+
+        // Creating all file nodes
+        for (var file : files.entrySet()) {
+            FileNode fileNode = packageNode.findOrCreateFileNode(getFileName(file.getValue()), getTreeStringBuilder().intern(file.getValue()));


Signed-off-by: Valentin Delaye <jonesbusy@gmail.com>

jonesbusy · 2023-12-28T08:08:06Z

Closing this PR. Will open a new clean one in the next few days.

Only need to finish method complexity parsing and enrich test coverage.

jonesbusy mentioned this pull request Oct 24, 2023

Support for OpenCover format jenkinsci/code-coverage-api-plugin#770

Closed

github-advanced-security bot found potential problems Oct 24, 2023

View reviewed changes

src/main/java/edu/hm/hafner/coverage/parser/OpenCoverParser.java Fixed Show fixed Hide fixed

jonesbusy force-pushed the feature/opencover-parser branch from 70f5055 to ed8ed23 Compare October 26, 2023 06:33

github-advanced-security bot found potential problems Oct 26, 2023

View reviewed changes

src/main/java/edu/hm/hafner/coverage/parser/OpenCoverParser.java Fixed Show fixed Hide fixed

src/main/java/edu/hm/hafner/coverage/parser/OpenCoverParser.java Fixed Show fixed Hide fixed

src/main/java/edu/hm/hafner/coverage/parser/OpenCoverParser.java Fixed Show fixed Hide fixed

jonesbusy force-pushed the feature/opencover-parser branch from ed8ed23 to 7ae8b9e Compare October 27, 2023 05:54

github-advanced-security bot found potential problems Oct 27, 2023

View reviewed changes

uhafner added the feature New features label Oct 27, 2023

jonesbusy force-pushed the feature/opencover-parser branch 2 times, most recently from 12ee519 to 3530ca2 Compare November 15, 2023 03:29

jonesbusy force-pushed the feature/opencover-parser branch 2 times, most recently from b4213f6 to 685043d Compare November 24, 2023 10:28

jonesbusy force-pushed the feature/opencover-parser branch from 685043d to a3daf0e Compare November 29, 2023 08:10

github-advanced-security bot found potential problems Nov 29, 2023

View reviewed changes

jonesbusy force-pushed the feature/opencover-parser branch from a3daf0e to d662db7 Compare December 1, 2023 06:28

jonesbusy force-pushed the feature/opencover-parser branch 7 times, most recently from 3a86a33 to 48d120d Compare December 22, 2023 09:50

jonesbusy force-pushed the feature/opencover-parser branch from 48d120d to fcffe54 Compare December 28, 2023 07:46

github-advanced-security bot found potential problems Dec 28, 2023

View reviewed changes

jonesbusy force-pushed the feature/opencover-parser branch from fcffe54 to 976bb7c Compare December 28, 2023 07:51

Add support for Opencover format based on opencover plugin

a173982

Signed-off-by: Valentin Delaye <jonesbusy@gmail.com>

jonesbusy force-pushed the feature/opencover-parser branch from 976bb7c to a173982 Compare December 28, 2023 08:07

jonesbusy closed this Dec 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

draft: Add support for OpenCover format based on opencover plugin #46

draft: Add support for OpenCover format based on opencover plugin #46

jonesbusy commented Oct 24, 2023

Submitter checklist

uhafner commented Nov 17, 2023

jonesbusy commented Nov 18, 2023

jonesbusy commented Dec 28, 2023

draft: Add support for OpenCover format based on opencover plugin #46

draft: Add support for OpenCover format based on opencover plugin #46

Conversation

jonesbusy commented Oct 24, 2023

Testing done

Submitter checklist

uhafner commented Nov 17, 2023

jonesbusy commented Nov 18, 2023

jonesbusy commented Dec 28, 2023