Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract a common base class for test parsers #70

Merged
merged 4 commits into from
Jan 24, 2024
Merged

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Jan 24, 2024

Remove some duplications in the test parsers.

@uhafner uhafner added the internal Internal changes without user or API impact label Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f57f7d0) 95.61% compared to head (4d3c5e5) 95.53%.
Report is 2 commits behind head on main.

Files Patch % Lines
...ava/edu/hm/hafner/coverage/parser/NunitParser.java 88.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #70      +/-   ##
============================================
- Coverage     95.61%   95.53%   -0.09%     
  Complexity      784      784              
============================================
  Files            28       29       +1     
  Lines          2008     1993      -15     
  Branches        285      282       -3     
============================================
- Hits           1920     1904      -16     
- Misses           44       45       +1     
  Partials         44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

☀️ Quality Monitor

  • 🚦 Tests: 284 tests passed
  • 👣 Code Coverage: 96% coverage achieved
  • 🔬 Mutation Coverage: 93% mutations killed
  • ⚠️ Style: No warnings found
  • 🐛 Bugs: No warnings found

More details are available in the GitHub Checks Result.

Copy link

☀️ Quality Monitor

  • 🚦 Tests: 284 tests passed
  • 👣 Code Coverage: 96% coverage achieved
  • 🔬 Mutation Coverage: 93% mutations killed
  • ⚠️ Style: No warnings found
  • 🐛 Bugs: No warnings found

More details are available in the GitHub Checks Result.

@uhafner uhafner merged commit 290fe0d into main Jan 24, 2024
29 of 30 checks passed
@uhafner uhafner deleted the coverage-base-class branch January 24, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal changes without user or API impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants