Skip to content
This repository has been archived by the owner on Sep 10, 2022. It is now read-only.

Add Editor and Routing functionality #40

Merged
merged 6 commits into from
Jun 10, 2020

Conversation

sladyn98
Copy link
Contributor

@sladyn98 sladyn98 commented Jun 6, 2020

This PR builds on top of the navigation bar addition and adds routing support as well as Editor page for displaying the package-config.yml

  • Adds Routing support

  • Adds editor template

@sladyn98 sladyn98 added the frontend Related to the front-end of the service label Jun 6, 2020
@sladyn98 sladyn98 added this to the [GSoC Phase 1] milestone Jun 6, 2020
@sladyn98 sladyn98 requested a review from a team as a code owner June 6, 2020 13:32
Copy link
Contributor

@kwhetstone kwhetstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a screen shot for this?

onValueChange={code => this.setState({ code })}
highlight={code => highlight(code, languages.js)}
padding={10}
style={{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually you might want to pull a lot of the css into a common file and inherit from that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is added as a property to it, I am not too sure if I can pull it out :(

@sladyn98
Copy link
Contributor Author

sladyn98 commented Jun 9, 2020

Do you have a screen shot for this?

@kwhetstone This was uploaded on the group :)

@sladyn98 sladyn98 merged commit 21f0c0c into jenkinsci:master Jun 10, 2020
@sladyn98 sladyn98 added the feature A PR that adds a feature label Aug 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature A PR that adds a feature frontend Related to the front-end of the service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Editor to show the generated packager-config.yml Implement generation of packager-config.yml
2 participants