Remove obsolete classes #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @author Oleg Nenashev | ||
| */ | ||
| //TODO: 1.567 provides a replacement | ||
| public class DecoratedLauncher extends Launcher { |
There was a problem hiding this comment.
This class is still a part of the public API though I do not see any usages in GitHub. I am fine with removing it
|
@oleg-nenashev is there anything to do or can it be merged? |
|
I believe this is okay.
This plugin just needs a maintainer to get it released
…On Thu, Mar 7, 2019, 23:18 René Scheibe ***@***.***> wrote:
@oleg-nenashev <https://github.com/oleg-nenashev> is there anything to do
or can it be merged?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#34 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC3IoOw84kaQqDlHW5bpOMNIrIFcRruMks5vUZAfgaJpZM4bBmil>
.
|
|
@oleg-nenashev could you at least merge it? |
|
@recampbell do you maintain this plugin? At least you are listed as |
|
No, the plugin has no active maintainer. I can deliver changes on-demand tho |
oleg-nenashev
approved these changes
Aug 10, 2019
|
This one will not hurt anyway |
|
Thanks. |
This was referenced Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JenkinsHelperandDecoratedLauncherare not required anymore.