Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-73963] Extract event handlers in CvsTagAction/tagForm.jelly #105

Merged
merged 8 commits into from
Oct 22, 2024
Merged

[JENKINS-73963] Extract event handlers in CvsTagAction/tagForm.jelly #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
817d769
extract JS in tagform.jelly
shlomomdahan Oct 21, 2024
b074c57
extract JS in tagform.jelly
shlomomdahan Oct 21, 2024
9c281ac
Merge branch 'master' into JENKINS-73963
shlomomdahan Oct 21, 2024
48ca48a
address comments
shlomomdahan Oct 22, 2024
53639eb
Merge remote-tracking branch 'origin/JENKINS-73963' into JENKINS-73963
shlomomdahan Oct 22, 2024
c3eb5f3
remove unnecessary id
shlomomdahan Oct 22, 2024
4fd84ef
Consistent formatting with other PRs
basil Oct 22, 2024
0b1d210
Consistent formatting with code before this PR and with code two line…
basil Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/main/resources/hudson/scm/cvstagging/CvsTagAction/create-another-tag.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
document.addEventListener("DOMContentLoaded", function () {
document.querySelector("#tagButton input").addEventListener("click", function () {
document.getElementById("tagForm").style.display = "block";
document.getElementById("tagButton").style.display = "none";
});
});
4 changes: 2 additions & 2 deletions src/main/resources/hudson/scm/cvstagging/CvsTagAction/tagForm.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,9 @@ THE SOFTWARE.
</p>

<j:if test="${h.hasPermission(it.build,it.permission)}">
<st:adjunct includes="hudson.scm.cvstagging.CvsTagAction.create-another-tag"/>
<p id="tagButton">
<input type="button" value="${%Create another tag}"
onclick="Element.show('tagForm');Element.hide('tagButton')"/>
<input type="button" value="${%Create another tag}"/>
</p>

<div id="tagForm" style="display:none;">
Expand Down