Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed missing "Excluded Region" field in CVS extended config settings #49

Merged
merged 1 commit into from
Mar 12, 2020

Conversation

mrmoritz01
Copy link
Contributor

This is an additional fix to PR #48 .
It re-enables the "Excluded Regions" textbox in CVS config so the handled nullpointer in PR #48 does not even occur.

excl_regions

@Glandos
Copy link

Glandos commented Jul 3, 2019

This simple patch works for me.

@Ryukyo
Copy link

Ryukyo commented Sep 5, 2019

Thank you for your solution.

I'm sorry for the simple question, usually my task is to write tests, but suddenly I was askked to revive the companies Jenkins. How do I implement this solution, as long as it is not included in the CVS-plugin downloadable through the Jenkins GUI?

I imported the project to Eclipse and made the change you suggested within the config.jelly. Do I have to export the whole project to a .jar and replace it in the plugins folder of the Jenkins server?
I haven't found a simple way to directly change the config.jelly on the Jenkins server

@mrmoritz01
Copy link
Contributor Author

mrmoritz01 commented Sep 6, 2019

Hi Ryukyo,
this is my approach to build the cvs plugin on Windows:
Install maven: https://maven.apache.org/
Then insert a small batch-File in the root folder of the cvs-plugin sources:
Set JAVA_HOME=D:\Tools\jdk8u212-b03
call D:\Tools\apache-maven-3.6.0-bin\apache-maven-3.6.0\bin\mvn.cmd clean javadoc:jar package

This will run a complete clean build and you will get an cvs.hpi file in the ./target folder.
You can upload this hpi file in the Jenkins Plugin Manager in the Advanced-Tab.

This might not be the "cleanest" or "nicest" way to do it, but it works for me.

emiliosmoreno added a commit to emiliosmoreno/cvs-plugin that referenced this pull request Dec 31, 2019
jenkinsci#49 fixed missing "Excluded Region" field in CVS extended config settings
@isotes
Copy link

isotes commented Jan 9, 2020

I've built an hpi file with the fix from @mrmoritz01 (thanks!) that has been working out great for me as well for a couple of weeks. It can be downloaded here and installed manually in the Jenkins Plugin Manager as described above.

@mrmoritz01 mrmoritz01 merged commit e8f17c7 into jenkinsci:master Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants