Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Jenkins 2.361.4 or newer #68

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 15, 2022

Bumps plugin from 4.49 to 4.53.

Release notes

Sourced from plugin's releases.

4.53

📦 Dependency updates

4.52

💥 Breaking changes

This release of the plugin build toolchain requires Java 11 or newer and Jenkins 2.361 or newer. Update jenkins.version in pom.xml to 2.361 or newer as described in the developer documentation, and adjust your Jenkinsfile to remove any Java 8 configurations. Note that in the absence of an explicit set of configurations, the default set of configurations still includes Java 8. The recommended set of configurations can be found in the archetype. Also note that pending JENKINS-46795 any changes to a repository's Jenkinsfile require write access to take effect in the PR build.

If you neglect to update jenkins.version to 2.361 or later, you will receive the following error:

This version of maven-hpi-plugin requires Jenkins 2.361 or later.

If you neglect to adjust your Jenkinsfile to remove any Java 8 configurations (or try to build locally with Java 8), you will receive a low-level class version error.

🚨 Removed

As part of the transition to Java 11, Animal Sniffer has been removed from the plugin parent POM. If you require the use of Animal Sniffer, ensure that you include it in your own POM.

📦 Dependency updates

4.51

🚀 New features and improvements

🐛 Bug fixes

  • Use project.basedir rather than maven.multiModuleProjectDirectory (#648) @​basil

📝 Documentation updates

📦 Dependency updates

... (truncated)

Commits
  • bd659b1 [maven-release-plugin] prepare release plugin-4.53
  • ae96031 Bump maven-hpi-plugin from 3.37 to 3.38 (#659)
  • 3f48663 Bump jenkins-test-harness (#658)
  • 4747a17 Bump access-modifier-checker from 1.29 to 1.30 (#657)
  • 1a6b694 Bump jenkins-test-harness (#656)
  • 684e3d9 [maven-release-plugin] prepare for next development iteration
  • f4b1eea [maven-release-plugin] prepare release plugin-4.52
  • 1abb634 Bump maven-hpi-plugin from 3.36 to 3.37 (#655)
  • cedb8a8 Bump jenkins-test-harness from 1900.v9e128c991ef4 to 1903.vf505ecb_63589 (#654)
  • adc397a Bump maven-stapler-plugin from 1.20 to 1.21 (#653)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [plugin](https://github.com/jenkinsci/plugin-pom) from 4.49 to 4.53.
- [Release notes](https://github.com/jenkinsci/plugin-pom/releases)
- [Changelog](https://github.com/jenkinsci/plugin-pom/blob/master/CHANGELOG.md)
- [Commits](jenkinsci/plugin-pom@plugin-4.49...plugin-4.53)

---
updated-dependencies:
- dependency-name: org.jenkins-ci.plugins:plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 15, 2022

The following labels could not be found: skip-changelog.

@gounthar
Copy link
Contributor

I'm not super proud of the suppress warning in the code, and I'm not so sure the simplification of the Jenkinsfile was really necessary.
What do you think?

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've offered an alternate phrasing for the suppression. Optional. Otherwise, ready to go

src/main/java/hudson/scm/CVSSCM.java Outdated Show resolved Hide resolved
@MarkEWaite MarkEWaite changed the title Bump plugin from 4.49 to 4.53 Require Jenkins 2.361.4 or newer Dec 15, 2022
@MarkEWaite MarkEWaite added the chore Maintenance label Dec 15, 2022
@gounthar
Copy link
Contributor

Much much better, thank you @MarkEWaite !

@gounthar gounthar merged commit cb87353 into master Dec 16, 2022
@gounthar gounthar deleted the dependabot/maven/master/org.jenkins-ci.plugins-plugin-4.53 branch December 16, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants