-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add live theme switching support #170
Conversation
src/main/java/io/jenkins/plugins/darktheme/DarkThemeRootAction.java
Outdated
Show resolved
Hide resolved
src/main/java/io/jenkins/plugins/darktheme/DarkThemeRootAction.java
Outdated
Show resolved
Hide resolved
Looks like CD has a hard time today. Not the first release that doesn't deploy 👀 |
Hmm I can't find the CD run for that one, there was a tag pushed though. Now it's failing for expired token. I think the job doesn't run quite often enough on trusted.ci, I've triggered it now |
Interesting, I've risen jenkins-infra/jenkins-maven-cd-action#16 earlier because of these silent fails. |
Seems the previous release did work it wasn't actually expired token. I think maybe multiple drafts broke release drafter publishing? I can see it in the update center now |
I currently have 8 drafts in https://github.com/jenkinsci/purge-build-queue-plugin/releases, if you can see that. |
Yeah I can see that, (owner permission on org). I wonder if that's breaking it, should be able to run the shell script locally to check. |
Yeah, that's it. I wiped the drafts and kept one, rebuild workflow from cli on master and it proceeded to the "release" step https://github.com/jenkinsci/purge-build-queue-plugin/runs/5325917358?check_suite_focus=true Edit: I'm using the release drafter action outside of Jenkins too and have repositories with several drafts, maybe this is not necessarily related to CD but GH actions/release drafter? |
@NotMyFault the one that failed will have actually released, you'll need to publish the release manually |
See jenkinsci/theme-manager-plugin#75
All themes are now loaded on every page, the active theme is controlled by a
data
attribute on thehtml
element.FYI @janfaracik