Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add live theme switching support #170

Merged
merged 7 commits into from
Feb 24, 2022
Merged

Add live theme switching support #170

merged 7 commits into from
Feb 24, 2022

Conversation

timja
Copy link
Member

@timja timja commented Feb 20, 2022

See jenkinsci/theme-manager-plugin#75

All themes are now loaded on every page, the active theme is controlled by a data attribute on the html element.

FYI @janfaracik

@timja timja marked this pull request as ready for review February 23, 2022 20:53
@timja timja requested a review from a team as a code owner February 23, 2022 20:53
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@timja timja requested a review from fqueiruga February 24, 2022 08:26
@timja timja added the enhancement New feature or request label Feb 24, 2022
@timja timja merged commit 2587a07 into jenkinsci:master Feb 24, 2022
@timja timja deleted the live-reload branch February 24, 2022 19:55
@NotMyFault
Copy link
Member

Looks like CD has a hard time today. Not the first release that doesn't deploy 👀

@timja
Copy link
Member Author

timja commented Feb 24, 2022

Hmm I can't find the CD run for that one, there was a tag pushed though.

Now it's failing for expired token. I think the job doesn't run quite often enough on trusted.ci, I've triggered it now

@NotMyFault
Copy link
Member

Interesting, I've risen jenkins-infra/jenkins-maven-cd-action#16 earlier because of these silent fails.

@timja
Copy link
Member Author

timja commented Feb 24, 2022

Seems the previous release did work it wasn't actually expired token. I think maybe multiple drafts broke release drafter publishing?

I can see it in the update center now

@NotMyFault
Copy link
Member

Seems the previous release did work it wasn't actually expired token. I think maybe multiple drafts broke release drafter publishing?

I currently have 8 drafts in https://github.com/jenkinsci/purge-build-queue-plugin/releases, if you can see that.
Kinda odd that release drafter/cd somewhat of spams drafts to then break it later on 🤔

@timja
Copy link
Member Author

timja commented Feb 24, 2022

Yeah I can see that, (owner permission on org).

I wonder if that's breaking it, should be able to run the shell script locally to check.

@NotMyFault
Copy link
Member

NotMyFault commented Feb 24, 2022

Yeah, that's it. I wiped the drafts and kept one, rebuild workflow from cli on master and it proceeded to the "release" step https://github.com/jenkinsci/purge-build-queue-plugin/runs/5325917358?check_suite_focus=true
However, that failed and created a new draft so we're back at step one 🥴

Edit: I'm using the release drafter action outside of Jenkins too and have repositories with several drafts, maybe this is not necessarily related to CD but GH actions/release drafter?

@timja
Copy link
Member Author

timja commented Feb 25, 2022

@NotMyFault the one that failed will have actually released, you'll need to publish the release manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants