Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump preview (EA) JDK21 version to 21.0.4+5 #772

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 16, 2024

Bump JDK21 preview version (EA) for all Linux images

Bump preview (EA) JDK21 version for Linux images in the docker-bake.hcl file

changes detected: path "variable.JAVA21_PREVIEW_VERSION.default" updated from "21.0.1+12" to "21.0.4+5" in file "docker-bake.hcl"

GitHub Action workflow link
Updatecli logo

Created automatically by Updatecli

Options:

Most of Updatecli configuration is done via its manifest(s).

  • If you close this pull request, Updatecli will automatically reopen it, the next time it runs.
  • If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.

Feel free to report any issues at github.com/updatecli/updatecli.
If you find this tool useful, do not hesitate to star our GitHub repository as a sign of appreciation, and/or to tell us directly on our chat!

@MarkEWaite
Copy link
Contributor

I think that the EA versions need to be replaced by released versions in this repository as was done for the controllers in:

Unfortunately, I'm not available at the moment to make that change. If others are interested in making the change, I'm happy to review the change.

@dduportal
Copy link
Contributor

The JDK21 preview covers 2 Linux platforms: linux/s390x and linux/arm/v7 as per

platforms = ["linux/s390x", "linux/arm/v7"]

For linux/s390x, it looks like there is an official stable JDK21 installer: https://adoptium.net/temurin/releases/?os=linux&arch=s390x. But there are non for linux/arm/v7: https://adoptium.net/temurin/releases/?os=linux&arch=arm

Same for the Docker image (which we build on top of): https://hub.docker.com/layers/library/eclipse-temurin/21.0.2_13-jdk-jammy/images/sha256-952185109e6790588902d524bd43fcf5f478e022847097ef9ae8ef5b82511bbd?context=explore

=> it means we can already move s390x out ofr "preview" for JDK21, but we'll have to decide (SIG Platform?) to keep or to drop support for arm32.

@MarkEWaite
Copy link
Contributor

=> it means we can already move s390x out of "preview" for JDK21, but we'll have to decide (SIG Platform?) to keep or to drop support for arm32.

Thanks for doing that investigation. The discussions in Platform SIG accepted that because Eclipse Temurin will not support armv7 after Java 17, the Jenkins project should not include armv7 images. Pull request

says:

The arm/v7 support that was added as a preview has been dropped because adoptium/adoptium-support#962 notes that the Eclipse Temurin project does not plan to deliver arm/v7 releases after Java 17.

@gounthar
Copy link
Contributor

I'll work on the move to "standard" JDK21 builds for s390X, and not preview anymore.

@github-actions github-actions bot changed the title Bump preview (EA) JDK21 version to 21.0.3+6 Bump preview (EA) JDK21 version to 21.0.3+7 Mar 22, 2024
@github-actions github-actions bot force-pushed the updatecli_master_ca584b5f81d8b07556f23824bd1a27d6f8f7a8d75cf7c9e47887b6ef9682ca44 branch from a25c8f7 to b2ddb3b Compare May 7, 2024 03:39
@github-actions github-actions bot changed the title Bump preview (EA) JDK21 version to 21.0.3+7 Bump preview (EA) JDK21 version to 21.0.4+1 May 7, 2024
@github-actions github-actions bot force-pushed the updatecli_master_ca584b5f81d8b07556f23824bd1a27d6f8f7a8d75cf7c9e47887b6ef9682ca44 branch 2 times, most recently from 5d9d2d4 to 9fdef66 Compare May 7, 2024 07:34
@github-actions github-actions bot force-pushed the updatecli_master_ca584b5f81d8b07556f23824bd1a27d6f8f7a8d75cf7c9e47887b6ef9682ca44 branch from 9fdef66 to ad5f7bd Compare May 7, 2024 10:40
@github-actions github-actions bot force-pushed the updatecli_master_ca584b5f81d8b07556f23824bd1a27d6f8f7a8d75cf7c9e47887b6ef9682ca44 branch from ad5f7bd to 3510800 Compare May 14, 2024 22:09
@github-actions github-actions bot changed the title Bump preview (EA) JDK21 version to 21.0.4+1 Bump preview (EA) JDK21 version to 21.0.4+2 May 14, 2024
@github-actions github-actions bot force-pushed the updatecli_master_ca584b5f81d8b07556f23824bd1a27d6f8f7a8d75cf7c9e47887b6ef9682ca44 branch 2 times, most recently from f7f5925 to 1dd7376 Compare May 15, 2024 03:12
@github-actions github-actions bot force-pushed the updatecli_master_ca584b5f81d8b07556f23824bd1a27d6f8f7a8d75cf7c9e47887b6ef9682ca44 branch 5 times, most recently from 76e65d5 to 3183ac2 Compare May 20, 2024 02:16
@github-actions github-actions bot changed the title Bump preview (EA) JDK21 version to 21.0.4+2 Bump preview (EA) JDK21 version to 21.0.4+3 May 20, 2024
@github-actions github-actions bot force-pushed the updatecli_master_ca584b5f81d8b07556f23824bd1a27d6f8f7a8d75cf7c9e47887b6ef9682ca44 branch from 3183ac2 to 5d4ce5c Compare May 27, 2024 02:16
@github-actions github-actions bot changed the title Bump preview (EA) JDK21 version to 21.0.4+3 Bump preview (EA) JDK21 version to 21.0.4+4 May 27, 2024
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI check fails with:

ERROR: failed to solve: process "/bin/bash -o pipefail -c set -x; apt-get update   && apt-get install --no-install-recommends -y     ca-certificates     jq     wget   && DASHED_JAVA_VERSION=$(echo \"$JAVA_VERSION\" | sed -e 's/\\./-/g' -e 's/+/-/' -e 's/21-35/21-0-35/')   && JAVA_MAJOR_VERSION=$(echo \"$JAVA_VERSION\" | cut -d'+' -f1 | cut -d'.' -f1)   && ENCODED_JAVA_VERSION=$(echo \"$JAVA_VERSION\" | jq \"@uri\" -jRr)   && CONVERTED_ARCH=$(arch | sed -e 's/x86_64/x64/' -e 's/armv7l/arm/')   && wget --quiet [https://github.com/adoptium/temurin\"${JAVA_MAJOR_VERSION}\"-binaries/releases/download/jdk-\"${ENCODED_JAVA_VERSION}\"-ea-beta/OpenJDK\"${JAVA_MAJOR_VERSION}\"U-jdk_\"${CONVERTED_ARCH}\"_linux_hotspot_ea_\"${DASHED_JAVA_VERSION}\".tar.gz](https://github.com/adoptium/temurin/%22$%7BJAVA_MAJOR_VERSION%7D/%22-binaries/releases/download/jdk-/%22$%7BENCODED_JAVA_VERSION%7D/%22-ea-beta/OpenJDK/%22$%7BJAVA_MAJOR_VERSION%7D/%22U-jdk_/%22$%7BCONVERTED_ARCH%7D/%22_linux_hotspot_ea_/%22$%7BDASHED_JAVA_VERSION%7D/%22.tar.gz) -O /tmp/jdk.tar.gz   && tar -xzf /tmp/jdk.tar.gz -C /opt/   && rm -f /tmp/jdk.tar.gz" did not complete successfully: exit code: 8

@gounthar
Copy link
Contributor

Failing for arm32.

377.4 + wget --quiet https://github.com/adoptium/temurin21-binaries/releases/download/jdk-21.0.4%2B4-ea-beta/OpenJDK21U-jdk_arm_linux_hotspot_ea_21-0-4-4.tar.gz -O /tmp/jdk.tar.gz
------
WARNING: No output specified for agent_archlinux_jdk11, inbound-agent_debian_21, agent_alpine_jdk11, inbound-agent_alpine_jdk21, agent_alpine_jdk21, inbound-agent_alpine_jdk11, agent_debian_17, inbound-agent_debian_17, agent_debian_11, agent_debian_21, inbound-agent_debian_jdk21_preview, agent_alpine_jdk17, agent_debian_jdk21_preview, inbound-agent_debian_11, inbound-agent_alpine_jdk17 target(s) with docker-container driver. Build result will only remain in the build cache. To push result image into registry use --push or to load image into docker use --load
Dockerfile:16
--------------------
  15 |     # hadolint ignore=DL3008
  16 | >>> RUN set -x; apt-get update \
  17 | >>>   && apt-get install --no-install-recommends -y \
  18 | >>>     ca-certificates \
  19 | >>>     jq \
  20 | >>>     wget \
  21 | >>>   && DASHED_JAVA_VERSION=$(echo "$JAVA_VERSION" | sed -e 's/\./-/g' -e 's/+/-/' -e 's/21-35/21-0-35/') \
  22 | >>>   && JAVA_MAJOR_VERSION=$(echo "$JAVA_VERSION" | cut -d'+' -f1 | cut -d'.' -f1) \
  23 | >>>   && ENCODED_JAVA_VERSION=$(echo "$JAVA_VERSION" | jq "@uri" -jRr) \
  24 | >>>   && CONVERTED_ARCH=$(arch | sed -e 's/x86_64/x64/' -e 's/armv7l/arm/') \
  25 | >>>   && wget --quiet https://github.com/adoptium/temurin"${JAVA_MAJOR_VERSION}"-binaries/releases/download/jdk-"${ENCODED_JAVA_VERSION}"-ea-beta/OpenJDK"${JAVA_MAJOR_VERSION}"U-jdk_"${CONVERTED_ARCH}"_linux_hotspot_ea_"${DASHED_JAVA_VERSION}".tar.gz -O /tmp/jdk.tar.gz \
  26 | >>>   && tar -xzf /tmp/jdk.tar.gz -C /opt/ \
  27 | >>>   && rm -f /tmp/jdk.tar.gz
  28 |

@github-actions github-actions bot force-pushed the updatecli_master_ca584b5f81d8b07556f23824bd1a27d6f8f7a8d75cf7c9e47887b6ef9682ca44 branch from 5d4ce5c to a26a375 Compare June 3, 2024 02:16
@github-actions github-actions bot changed the title Bump preview (EA) JDK21 version to 21.0.4+4 Bump preview (EA) JDK21 version to 21.0.4+5 Jun 3, 2024
@github-actions github-actions bot force-pushed the updatecli_master_ca584b5f81d8b07556f23824bd1a27d6f8f7a8d75cf7c9e47887b6ef9682ca44 branch 2 times, most recently from 0d0051e to 692ccbf Compare June 3, 2024 16:25
@gounthar
Copy link
Contributor

gounthar commented Jun 3, 2024

Still arm32 of course...

18:44:05  WARNING: No output specified for inbound-agent_alpine_jdk17, inbound-agent_debian_jdk21_preview, agent_alpine_jdk11, inbound-agent_debian_11, agent_debian_21, inbound-agent_debian_21, agent_alpine_jdk21, agent_debian_jdk21_preview, inbound-agent_alpine_jdk11, inbound-agent_alpine_jdk21, agent_debian_11, agent_archlinux_jdk11, agent_alpine_jdk17, inbound-agent_debian_17, agent_debian_17 target(s) with docker-container driver. Build result will only remain in the build cache. To push result image into registry use --push or to load image into docker use --load
18:44:05  Dockerfile:16
18:44:05  --------------------
18:44:05    15 |     # hadolint ignore=DL3008
18:44:05    16 | >>> RUN set -x; apt-get update \
18:44:05    17 | >>>   && apt-get install --no-install-recommends -y \
18:44:05    18 | >>>     ca-certificates \
18:44:05    19 | >>>     jq \
18:44:05    20 | >>>     wget \
18:44:05    21 | >>>   && DASHED_JAVA_VERSION=$(echo "$JAVA_VERSION" | sed -e 's/\./-/g' -e 's/+/-/' -e 's/21-35/21-0-35/') \
18:44:05    22 | >>>   && JAVA_MAJOR_VERSION=$(echo "$JAVA_VERSION" | cut -d'+' -f1 | cut -d'.' -f1) \
18:44:05    23 | >>>   && ENCODED_JAVA_VERSION=$(echo "$JAVA_VERSION" | jq "@uri" -jRr) \
18:44:05    24 | >>>   && CONVERTED_ARCH=$(arch | sed -e 's/x86_64/x64/' -e 's/armv7l/arm/') \
18:44:05    25 | >>>   && wget --quiet [https://github.com/adoptium/temurin"${JAVA_MAJOR_VERSION}"-binaries/releases/download/jdk-"${ENCODED_JAVA_VERSION}"-ea-beta/OpenJDK"${JAVA_MAJOR_VERSION}"U-jdk_"${CONVERTED_ARCH}"_linux_hotspot_ea_"${DASHED_JAVA_VERSION}".tar.gz](https://github.com/adoptium/temurin%22$%7BJAVA_MAJOR_VERSION%7D%22-binaries/releases/download/jdk-%22$%7BENCODED_JAVA_VERSION%7D%22-ea-beta/OpenJDK%22$%7BJAVA_MAJOR_VERSION%7D%22U-jdk_%22$%7BCONVERTED_ARCH%7D%22_linux_hotspot_ea_%22$%7BDASHED_JAVA_VERSION%7D%22.tar.gz) -O /tmp/jdk.tar.gz \
18:44:05    26 | >>>   && tar -xzf /tmp/jdk.tar.gz -C /opt/ \
18:44:05    27 | >>>   && rm -f /tmp/jdk.tar.gz
18:44:05    28 |     
18:44:05  --------------------
18:44:05  ERROR: failed to solve: process "/bin/bash -o pipefail -c set -x; apt-get update   && apt-get install --no-install-recommends -y     ca-certificates     jq     wget   && DASHED_JAVA_VERSION=$(echo \"$JAVA_VERSION\" | sed -e 's/\\./-/g' -e 's/+/-/' -e 's/21-35/21-0-35/')   && JAVA_MAJOR_VERSION=$(echo \"$JAVA_VERSION\" | cut -d'+' -f1 | cut -d'.' -f1)   && ENCODED_JAVA_VERSION=$(echo \"$JAVA_VERSION\" | jq \"@uri\" -jRr)   && CONVERTED_ARCH=$(arch | sed -e 's/x86_64/x64/' -e 's/armv7l/arm/')   && wget --quiet [https://github.com/adoptium/temurin\"${JAVA_MAJOR_VERSION}\"-binaries/releases/download/jdk-\"${ENCODED_JAVA_VERSION}\"-ea-beta/OpenJDK\"${JAVA_MAJOR_VERSION}\"U-jdk_\"${CONVERTED_ARCH}\"_linux_hotspot_ea_\"${DASHED_JAVA_VERSION}\".tar.gz](https://github.com/adoptium/temurin/%22$%7BJAVA_MAJOR_VERSION%7D/%22-binaries/releases/download/jdk-/%22$%7BENCODED_JAVA_VERSION%7D/%22-ea-beta/OpenJDK/%22$%7BJAVA_MAJOR_VERSION%7D/%22U-jdk_/%22$%7BCONVERTED_ARCH%7D/%22_linux_hotspot_ea_/%22$%7BDASHED_JAVA_VERSION%7D/%22.tar.gz) -O /tmp/jdk.tar.gz   && tar -xzf /tmp/jdk.tar.gz -C /opt/   && rm -f /tmp/jdk.tar.gz" did not complete successfully: exit code: 8
script returned exit code 1

@github-actions github-actions bot force-pushed the updatecli_master_ca584b5f81d8b07556f23824bd1a27d6f8f7a8d75cf7c9e47887b6ef9682ca44 branch from 692ccbf to 401f003 Compare June 17, 2024 06:52
@gounthar
Copy link
Contributor

Still failing for arm32.

09:08:49  462.7 + CONVERTED_ARCH=arm
09:08:49  462.7 + wget --quiet https://github.com/adoptium/temurin21-binaries/releases/download/jdk-21.0.4%2B5-ea-beta/OpenJDK21U-jdk_arm_linux_hotspot_ea_21-0-4-5.tar.gz -O /tmp/jdk.tar.gz
09:08:49  ------
09:08:49  WARNING: No output specified for agent_alpine_jdk21, agent_debian_jdk21_preview, inbound-agent_debian_21, inbound-agent_alpine_jdk11, inbound-agent_debian_jdk21_preview, agent_alpine_jdk17, agent_debian_17, inbound-agent_debian_17, agent_debian_11, agent_alpine_jdk11, inbound-agent_alpine_jdk21, inbound-agent_alpine_jdk17, inbound-agent_debian_11, agent_debian_21, agent_archlinux_jdk11 target(s) with docker-container driver. Build result will only remain in the build cache. To push result image into registry use --push or to load image into docker use --load
09:08:49  Dockerfile:16

@dduportal
Copy link
Contributor

Still failing for arm32.

09:08:49  462.7 + CONVERTED_ARCH=arm
09:08:49  462.7 + wget --quiet https://github.com/adoptium/temurin21-binaries/releases/download/jdk-21.0.4%2B5-ea-beta/OpenJDK21U-jdk_arm_linux_hotspot_ea_21-0-4-5.tar.gz -O /tmp/jdk.tar.gz
09:08:49  ------
09:08:49  WARNING: No output specified for agent_alpine_jdk21, agent_debian_jdk21_preview, inbound-agent_debian_21, inbound-agent_alpine_jdk11, inbound-agent_debian_jdk21_preview, agent_alpine_jdk17, agent_debian_17, inbound-agent_debian_17, agent_debian_11, agent_alpine_jdk11, inbound-agent_alpine_jdk21, inbound-agent_alpine_jdk17, inbound-agent_debian_11, agent_debian_21, agent_archlinux_jdk11 target(s) with docker-container driver. Build result will only remain in the build cache. To push result image into registry use --push or to load image into docker use --load
09:08:49  Dockerfile:16

@gounthar what do you think if we open PR removing the updatecli manifest tracking the EA JDK21 version since it does not work anymore with new versions?

@gounthar gounthar mentioned this pull request Jun 17, 2024
5 tasks
... -bake.hcl file

Made with ❤️️ by updatecli
@github-actions github-actions bot force-pushed the updatecli_master_ca584b5f81d8b07556f23824bd1a27d6f8f7a8d75cf7c9e47887b6ef9682ca44 branch from 401f003 to e2b4ad6 Compare June 17, 2024 11:42
@lemeurherve lemeurherve deleted the updatecli_master_ca584b5f81d8b07556f23824bd1a27d6f8f7a8d75cf7c9e47887b6ef9682ca44 branch June 17, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants