Retries in ConnectionCheckSSH

[php50350]

In the execute method of ConnectionCheckSSH, there is a line of code as follow:

final int retries = Math.min(0, parent.retries);

That causes the number of retries to be always 0 (unless the parent.retries is negative). The result is that when the plugin starts a Docker container and then attempts to connect to it, the error "java.io.IOException: SSH service hadn't started after 0 seconds." will often be encountered.

[pjdarton]

"oops"
Yes, that looks like a bit of an oversight on my part.
...and that code had no a faulty unit-test so this one slipped through.

I'll fix it.

[pjdarton]

OK, I've created PR #752 that should fix this.

It's been built by ci.jenkins.io and you can get a .hpi file from the "Last Successful Artifacts" listed under https://ci.jenkins.io/job/Plugins/job/docker-plugin/job/PR-752/
Please download it, install it on your Jenkins server(s) [manage jenkins -> manage plugins -> advanced], test that it fixes the bug for you and let me know the results (here).
If it's all confirmed ok then I'll release the fix officially.

[pjdarton]

...also, if you could check the code changes (in #752) then that would be helpful - it would be rather embarrassing if the fix for this was also buggy... 😉

[php50350]

Thank you for taking a quick response to fix the issue. I did a quick test using the updated plugin in my system and it works fine :)

[pjdarton]

OK, thanks for confirming the fix.
I've merged the code changes into master and this will be fixed in the next release.

[pjdarton]

Code changes went into released of docker-plugin version 1.1.9