Add docker run --dns-search flag to agent template #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can anyone review this please? |
|
Hi @kirk-fitz, thanks for the PR! Let me review it over the next few days |
krisstern
approved these changes
Oct 12, 2024
|
Thanks for reviewing @krisstern, does a maintainer need to create a release manually? Cd isnt setup on the repo? |
|
Hi @kirk-fitz, you are welcome! I think I will need to update the Jenkins version in "pom.xml" first within the next few hours before I manually release a new version of the plugin shortly afterwards. But I promise I will do it ASAP. |
|
Okay, thank you
…On Sat 12 Oct 2024, 15:00 Kris Stern, ***@***.***> wrote:
Hi @kirk-fitz <https://github.com/kirk-fitz>, you are welcome! I think I
will need to update the Jenkins version in "pom.xml" first within the next
few hours before I manually release a new version of the plugin shortly
afterwards. But I promise I will do it ASAP.
—
Reply to this email directly, view it on GitHub
<#1105 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BKA4AWHYT76GS6G4DKGKVIDZ3ETODAVCNFSM6AAAAABPPUJZQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGU3TINZUGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to be able to add --dns-search flag to agent template run command.
https://docs.docker.com/engine/network/
I have created this issue #1104
I believe this PR addresses this issue, but I have been unable to test this in full due to environment issues.
Testing done
I was able to do a quick manual test and I can see the field for the --dns-search in the GUI and when I provision an agent via the template I can see the correct entry in the /etc/resolv.conf file in the container
Submitter checklist