Allow randomizing cloud selection #1116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple Docker clouds are defined, the plugin will always create agents from the first available cloud, not allowing to distribute the load on all the clouds that are defined. Possible solutions to this issue are: - Docker Swarm Standalone, which is deprecated - Docker Engine Swarm API, which is not supported by docker-plugin. This changes adds a setting that enables randomizing the order in which Docker clouds are tried when creating a new agent.
cavedon
force-pushed
the
randomize-cloud
branch
from
fe793d4 to
f2c6004
Compare
|
I configured two Docker clouds, one a copy of the other, and watched the allocation. As far as I could tell, it was always choosing the first cloud, whether or not the randomization checkbox was enabled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple Docker clouds are defined, the plugin will always create agents from the first available cloud, not allowing to distribute the load on all the clouds that are defined.
Possible solutions to this issue are:
This changes adds a setting that enables randomizing the order in which Docker clouds are tried when creating a new agent.
Testing done
Tested on a Jenkins instance with two Docker clouds defined, with the setting enabled and disables.
I did not find existing unit tests coverage for FastNodeProvisionerStrategy where to add my tests...
Submitter checklist