Waiter until ssh connection can be estabilished #230
Conversation
lanwen
changed the title
|
This conflicts with my work where i'm cleanuping DockerTemplate/Base/Slave/launcher and other classes. I'm unbundling launchers. So i wouldn't merge this change. |
lanwen
changed the title
| LOGGER.info("Try to connect to sshd on {}:{}", host, port); | ||
|
|
||
| waitForSshOn(host, port); | ||
| super.launch(computer, listener); |
There was a problem hiding this comment.
I think after #234 it will be possible just to have retries as additional option for DockerSSHComputerLauncher, because it already wrapping sshlauncher/sshconnector to have ability to choose/configure launcher in UI.
| * @param time number of units | ||
| * @param units to convert to millis | ||
| */ | ||
| private static void sleepFor(int time, TimeUnit units) { |
|
Could you send in separate PR PortUtils changes without removing/adding ssh launcher? |
|
And could you unhardcode timeout values? |
lanwen
changed the title
- also remove unused method - add javadocs - every timeout settable
| socket = new Socket(host, port); | ||
| available = true; | ||
| private int retries = 10; | ||
| private int sshTimeoutMillis = (int) SECONDS.toMillis(2); |
There was a problem hiding this comment.
ConnectionInfo connect(ServerHostKeyVerifier verifier, int connectTimeout, int readTimeout, int kexTimeout) - that's the main cause of int cast
Waiter until ssh connection can be estabilished
| } | ||
|
|
||
| /** | ||
| * @param host hostname to connect to |
There was a problem hiding this comment.
Some description about what kind of connection required: tcp/udp/ssh?
There was a problem hiding this comment.
only tcp. Will add it next time
also: