-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JENKINS-30200: Nullpointer exception while connecting to a docker #320
Conversation
container Looks like due to Docker API changes between `v1.19` and `v1.20` create container call should contain `ExposedPorts` instead of `PortSpecs`. Change was tested with Docker `1.8.2` and `1.7.1`.
What image did you use for testing? |
I've used my own docker image, created following steps listed on Docker Plugin. Used docker image should not have nay impact IMO. Here is dockerfile I've used for my image:
|
This is the main problem, image should have EXPOSE place, that's why https://github.com/jenkinsci/docker-plugin/blob/master/CONTRIBUTING.md as the first step asks to use verified image. Also old launching code was hardcoded to expect EXPOSE 22, that i probably unhardcoded. Without integration tests i don't want change behaviour now. Relates to #309 |
I see. Thank you for few more links. |
@djaara feel free to investigate and provide results :) I think the same issue will be if somebody wants expose additional port in template. I hope wrote integration tests soon so it will be possible to play with changes. |
retriggering pr for user on IRC. Surprised that @magnayn not merged all PRs yet. |
JENKINS-30200: Nullpointer exception while connecting to a docker
It was sarcasm ;) |
container
Looks like due to Docker API changes between
v1.19
andv1.20
create container call should contain
ExposedPorts
instead ofPortSpecs
. Change was tested with Docker1.8.2
and1.7.1
.