JNLP Enhancement #654
Merged
JNLP Enhancement #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Containers that connect via JNLP can now specify a their own custom entry point arguments.
pjdarton
added
bug
Prerequisites for all 3 methods are now bullet-pointed lists. SSH now specifies that login details are needed as per ssh-slaves plugin. JNLP now specifies that slave.jar is needed. JNLP's entrypoint argument help improved to make it clear that the multi-line string needs to be expanded before being edited. Example of custom command now mentions that it requires wget. Also, moved details of the default setting to the bottom of the help text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Containers that connect via JNLP can now specify a their own custom entry point arguments.
This enhancement should resolve issue #635 by allowing folks to change the entry point arguments back to the way they were in version 1.1.2 of the plugin.