Fix Docker Jenkins JNLP Agent image name #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The repository is jenkinsci/docker-jnlp-slave but the Docker image name is jenkins/jnlp-slave. Fixing this will prevent incorrect copy/paste for users who want to try it.
pjdarton
suggested changes
Nov 18, 2019
src/main/resources/io/jenkins/docker/connector/DockerComputerAttachConnector/config.jelly
Outdated
Show resolved
Hide resolved
Based on @pjdarton to link to source and docker image locations. Co-Authored-By: Peter Darton <pjdarton@users.noreply.github.com>
|
@pjdarton I'm really really sorry for the force-push.. I hate to do that on PRs but I mis-wrote your handle on the first try. |
pjdarton
approved these changes
Nov 19, 2019
|
Sometimes a re-base and force-push is the right thing to do - in this case, the changes were small enough that it was not an inconvenience. It all looks good now. |
|
Code changes went into released of docker-plugin version 1.1.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repository is jenkinsci/docker-jnlp-slave but the Docker image name is jenkins/jnlp-slave.
Fixing this will prevent incorrect copy/paste for users who want to try it.