Update unit-tests to cope with recent changes in jenkins/ssh-agent docker image. #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- it used to be necessary, but no longer - ...and now java isn't where it used to be either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit tests have broken due to changes in the jenkins/ssh-agent docker image.
jenkins/ssh-agent used to have Java at
/usr/local/openjdk-8/bin/javaAt one point it stopped putting that on the $PATH, so we had to tell Jenkins where to find it.
Now it's moved (to
/opt/java/openjdk/bin/java) but it's back on the path so Jenkins will auto-find it again.TL;DR: Removing this configuration seems to allow the test to pass again.