Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for sunset icon removal from core #870

Merged

Conversation

NotMyFault
Copy link
Member

@NotMyFault NotMyFault commented Dec 12, 2021

This is a preparation for jenkinsci/jenkins#5778 which removes sunset icons.

Otherwise we're lacking an icon here:

Which has been mitigated:

cc @pjdarton

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@NotMyFault NotMyFault force-pushed the chore/master/prep-for-core-5778 branch from 75898d0 to fef7708 Compare December 12, 2021 21:35
@pjdarton
Copy link
Member

The automated tests have failed 3 times in a row but that seems to be a jenkinsci infrastructure issue rather than anything to do with the code ...
I'll take this one "on trust" and merge it.

...is there any rush to push out a new release, or is that some way down the line e.g. next year?

@pjdarton pjdarton merged commit ffd3949 into jenkinsci:master Dec 13, 2021
@NotMyFault NotMyFault deleted the chore/master/prep-for-core-5778 branch December 13, 2021 11:58
@NotMyFault
Copy link
Member Author

The core PR I mentioned is on hold until some other PRs are merged, like this one. Depending on when it's merged, it may be part of the next LTS release but definitely will be part of any weekly release in the sooner future.
timja has asked authors to draft a release for it e.g. in https://github.com/jenkinsci/pipeline-stage-view-plugin/pull/182#issuecomment-991922805 but I'm not sure if there's a general policy for it.

But in my opinion it would be handy to have plugins to drop releases before core updates, to prevent missing icons in the UI.

@pjdarton
Copy link
Member

Released as docker-plugin-1.2.6.hpi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants